Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Toolbar) convert demos to TS #9475

Merged
merged 3 commits into from
Oct 16, 2023
Merged

chore(Toolbar) convert demos to TS #9475

merged 3 commits into from
Oct 16, 2023

Conversation

Dominik-Petrik
Copy link
Contributor

What: Closes #9448

@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 8, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-9475.surge.sh

A11y report: https://patternfly-react-pr-9475-a11y.surge.sh

@jenny-s51 jenny-s51 force-pushed the toolbar-convertDemoToTS branch 2 times, most recently from 1b7eab8 to 7f3b179 Compare September 18, 2023 19:56
@jenny-s51 jenny-s51 force-pushed the toolbar-convertDemoToTS branch from bd72fb2 to ab1080a Compare October 9, 2023 19:27
@Dominik-Petrik @jenny-s51
chore(Toolbar) convert demos to TS
b8f9e0e 
PR feedback from ERic and Titani

update to menu footer button

revert to js to fix ci
@jenny-s51 jenny-s51 force-pushed the toolbar-convertDemoToTS branch from ab1080a to b8f9e0e Compare October 9, 2023 19:43
wise-king-sullyman
wise-king-sullyman requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing I noticed TS complaining about: it looks like the type for the event arg of onPageResize on line 172 needs to be updated to MouseEvent | TouchEvent | React.KeyboardEvent<Element>.

thatblindgeye
thatblindgeye requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the leftAlignedItemsDesktop content, we just need to add role="menu" to the first Select. Then similarly for leftAlignedItemsMobile, we need to add onOpenChangeKeys={['Escape']} to the first Select.

thatblindgeye
thatblindgeye approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 lgtm

There's one thing axe is flagging on the smaller viewport width related to the aria-controls on the search input icon that I want to look at a little further, but that's a followup issue unrelated to the updates made in this PR

wise-king-sullyman
wise-king-sullyman approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wise-king-sullyman wise-king-sullyman merged commit 8642588 into patternfly:main Oct 16, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.2.0-prerelease.9
  • @patternfly/react-core@5.2.0-prerelease.9
  • @patternfly/react-docs@6.2.0-prerelease.9
  • demo-app-ts@5.1.1-prerelease.32
  • @patternfly/react-table@5.2.0-prerelease.9

Thanks for your contribution! 🎉

@renovate renovate bot mentioned this pull request May 1, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlabaj tlabaj tlabaj left review comments

@jenny-s51 jenny-s51 jenny-s51 left review comments

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert toolbar react demo to TS
7 participants
@Dominik-Petrik @patternfly-build @wise-king-sullyman @jenny-s51 @tlabaj @kmcfaul @thatblindgeye