feat(FocusTrap): convert to function component #9297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-9297.surge.sh A11y report: https://patternfly-react-pr-9297-a11y.surge.sh |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
jonkoops
force-pushed
the
focus-trap-fn-component
branch
from
0b921d0 to
4b2bcbc
Compare
jonkoops
force-pushed
the
focus-trap-fn-component
branch
from
4b2bcbc to
148adb3
Compare
kmcfaul
approved these changes
Aug 22, 2023
thatblindgeye
approved these changes
Aug 22, 2023
|
Thanks for helping me land this all! |
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the
FocusTrapcomponent to a function component, and aligns it so it can work with strict null checks in TypeScript.Works towards closing #7889