introduce preselectedType for AccessConsoles component #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mareklibra
force-pushed
the
AccessConsoles.fixIfNotPresent
branch
from
cab2260 to
2f66053
Compare
|
Cc @lizsurette |
mareklibra
changed the title
mareklibra
force-pushed
the
AccessConsoles.fixIfNotPresent
branch
from
2f66053 to
23f080d
Compare
|
PatternFly-React preview: https://906-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 3320
💛 - Coveralls |
jeff-phillips-18
previously approved these changes
Nov 13, 2018
|
Cc @lizsurette , can you please have a look? This just enables pre-selection one of the consoles within AccessConsoles, so the initial state is not empty from the user perspective. |
|
@mareklibra This looks great to me! I think this should be the default, honestly. |
dtaylor113
previously approved these changes
Nov 20, 2018
Only available consoles are listed in the AccessConsole's dropdown. Prior this fix, all component types were always listed.
The AccessConsoles component can be newly requested to render particular console type by default instead of just empty space.
mareklibra
dismissed stale reviews from dtaylor113 and jeff-phillips-18
via
d011eb4
mareklibra
force-pushed
the
AccessConsoles.fixIfNotPresent
branch
from
23f080d to
d011eb4
Compare
|
Rebased to resolve conflict only. |
|
@dtaylor113 , @jeff-phillips-18 , can you please have another look? |
jeff-phillips-18
approved these changes
Nov 26, 2018
dtaylor113
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: introduce
preselectedTypeforAccessConsolescomponentPrior this patch, the component started "empty" (no console rendered).
The new property can be used to pre-select particular component for initial state.
As a part of this PR, fix for not-rendering unlisted console types is provided.