Charts - fix broken tooltip examples for v5 #8592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-8592.surge.sh A11y report: https://patternfly-react-pr-8592-a11y.surge.sh |
…new div tag in the SVG patternfly#8591
dlabrecq
force-pushed
the
v5-8591-tooltip-examples
branch
from
1ed8144
to
d2d6a30
Compare
nicolethoen
reviewed
Jan 27, 2023
| @@ -297,7 +297,7 @@ This demonstrates how to embed HTML within a tooltip. Combining cursor and voron | |||
|
|
|||
| ```js | |||
| import React from 'react'; | |||
| import { Chart, ChartArea, ChartAxis, ChartCursorFlyout, ChartCursorTooltip, ChartGroup, ChartPoint, ChartThemeColor } from '@patternfly/react-charts'; | |||
| import { Chart, ChartArea, ChartAxis, ChartCursorFlyout, ChartCursorTooltip, ChartGroup, ChartPoint, ChartThemeColor, createContainer } from '@patternfly/react-charts'; | |||
There was a problem hiding this comment.
I think createContainer is an unnecessary unused import
There was a problem hiding this comment.
It's used just below on line 315. I noticed it because CodeSandbox fails to load the example without it.
|
This will also likely need a code mod, right? To at least warn users that are using tooltips in charts that they need to wrap them in foreignObjects? |
|
This particular example is more to show how to create a custom label component. However, I've created the codemod issue below. |
nicolethoen
approved these changes
Feb 2, 2023
kmcfaul
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to fix two broken legend tooltip examples due to the Tooltip popper outputting a new div tag.
#8591