-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(hasCheckbox): rename hasCheck to hasCheckbox #8403
Conversation
Preview: https://patternfly-react-pr-8403.surge.sh A11y report: https://patternfly-react-pr-8403-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these updates! Had some changes below, mainly regarding the update to the old hasChecks
prop.
packages/react-core/src/components/DualListSelector/DualListSelector.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Switch/examples/SwitchCheckedWithLabel.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/TreeView/__tests__/TreeView.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/TreeView/examples/TreeView.md
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/TreeView/examples/TreeView.md
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/ComposableMenu/examples/ComposableTreeViewMenu.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/ComposableMenu/examples/ComposableTreeViewMenu.tsx
Outdated
Show resolved
Hide resolved
Thanks for the feedback @thatblindgeye I updated based on the above, if you feel I missed anything feel free to give me a shout 😄 |
packages/react-core/src/components/DualListSelector/DualListSelector.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these updates! I had a comment below regarding the one of the jobs failing for this PR
Additionally regarding the initial commit message of fix(hasChange): updated reference to hasCheckbox
, that could be updated to more closely match our commit message convention #8134 is a PR similar where a prop was renamed.
packages/react-core/src/demos/ComposableMenu/examples/ComposableTreeViewMenu.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/Filters/examples/FilterFaceted.tsx
Outdated
Show resolved
Hide resolved
@thatblindgeye I updated as per above. I noticed the I'm not sure how my changes may have effected these tests but the changes are along the lines of changing dates, as an example
I did not push these changes as they may be outside the scope of this ticket and might be an issue with local times etc Note: all tests seem to have passed since writing the above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bonjo7 I reran the failed job and it's now passing! Thanks for mentioning that and for making these updates 🎉
Ah perfect, thanks for the feedback/help, I finally got there in the end. 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue 8126
What
Updated reference from
hasCheck
tohasCheckbox
@tlabaj updated PR in reference to
hasCheckbox
Additional issues: