Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select/TextInput): fix components typescript interfaces #833

Merged
merged 1 commit into from
Oct 26, 2018
Merged

fix(Select/TextInput): fix components typescript interfaces #833

merged 1 commit into from
Oct 26, 2018

Conversation

boaz0
Copy link
Member

@boaz0 boaz0 commented Oct 25, 2018

A small fix to the typescript check when using TextInput and Select.
There is inconsistency between PropTypes and TypeScript checks.

For example, in TextInput according to PropTypes onChange is optional and its default value is noop (http://patternfly-react.surge.sh/patternfly-4/components/textinput). However, in TypeScript it's a required prop.

text_input

Another example is in Select, on one hand onBlur is not required, TS check fails saying onBlur is required.

select

I updated TS check according to what is given in http://patternfly-react.surge.sh/patternfly-4/

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://833-pr-patternfly-react-patternfly.surge.sh

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2829

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.163%

Totals Coverage Status
Change from base Build 2821: 0.0%
Covered Lines: 3423
Relevant Lines: 3976

💛 - Coveralls

Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tlabaj tlabaj merged commit 4011d86 into patternfly:master Oct 26, 2018
@boaz0 boaz0 deleted the input_ts_props branch October 26, 2018 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants