fix(Select/TextInput): fix components typescript interfaces #833
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix to the typescript check when using
TextInput
andSelect
.There is inconsistency between PropTypes and TypeScript checks.
For example, in
TextInput
according to PropTypesonChange
is optional and its default value isnoop
(http://patternfly-react.surge.sh/patternfly-4/components/textinput). However, in TypeScript it's a required prop.Another example is in
Select
, on one handonBlur
is not required, TS check fails sayingonBlur
is required.I updated TS check according to what is given in http://patternfly-react.surge.sh/patternfly-4/