Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Slider): correct tab order when input is above thumb #8190

Merged
merged 1 commit into from
Oct 13, 2022
Merged

fix(Slider): correct tab order when input is above thumb #8190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/react-core/src/components/Slider/Slider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,16 +416,16 @@ export const Slider: React.FunctionComponent<SliderProps> = ({
{buildSteps()}
</div>
)}
{isInputVisible && inputPosition === 'aboveThumb' && (
<div className={css(styles.sliderValue, styles.modifiers.floating)}>{displayInput()}</div>
)}
{hasTooltipOverThumb ? (
<Tooltip entryDelay={0} content={findAriaTextValue()}>
{thumbComponent}
</Tooltip>
) : (
thumbComponent
)}
{isInputVisible && inputPosition === 'aboveThumb' && (
<div className={css(styles.sliderValue, styles.modifiers.floating)}>{displayInput()}</div>
)}
</div>
{isInputVisible && inputPosition === 'right' && <div className={css(styles.sliderValue)}>{displayInput()}</div>}
{rightActions && <div className={css(styles.sliderActions)}>{rightActions}</div>}
Expand Down
22 changes: 11 additions & 11 deletions packages/react-core/src/components/Slider/_tests_/__snapshots__/Slider.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,17 +475,6 @@ exports[`slider renders slider with input above thumb 1`] = `
</div>
</div>
</div>
<div
aria-disabled="false"
aria-label="Value"
aria-valuemax="100"
aria-valuemin="0"
aria-valuenow="50"
aria-valuetext="50"
class="pf-c-slider__thumb"
role="slider"
tabindex="0"
/>
<div
class="pf-c-slider__value pf-m-floating"
>
Expand All @@ -509,6 +498,17 @@ exports[`slider renders slider with input above thumb 1`] = `
</span>
</div>
</div>
<div
aria-disabled="false"
aria-label="Value"
aria-valuemax="100"
aria-valuemin="0"
aria-valuenow="50"
aria-valuetext="50"
class="pf-c-slider__thumb"
role="slider"
tabindex="0"
/>
</div>
</div>
</DocumentFragment>
Expand Down