-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Page) remove deprecated props #8185
Conversation
Preview: https://patternfly-react-pr-8185.surge.sh A11y report: https://patternfly-react-pr-8185-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! Had a couple of questions which @tlabaj may be able to weigh in on:
- The snapshots look to have been updated where the
pf-m-sticky-[top/bottom]
class is removed, and asticky
attribute is instead added. Should thepf-m-sticky
class not still be applied in the snapshots? - In the PageHeader component, the
isManagedSidebar
prop description mentions "This prop is no longer managed through PageHeader but in the Page component", and the prop is also given the alias ofdeprecatedIsManagedSidebar
on line 46. Would we want to remove this prop as well or add a proper@deprecated
in the description?
@thatblindgeye is correct.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address @thatblindgeye comments
2d02681
to
33ee401
Compare
- @patternfly/react-catalog-view-extension@4.92.27 - @patternfly/react-code-editor@4.82.27 - @patternfly/react-console@4.92.27 - @patternfly/react-core@4.250.2 - @patternfly/react-docs@5.102.32 - @patternfly/react-inline-edit-extension@4.86.28 - demo-app-ts@4.202.8 - @patternfly/react-log-viewer@4.87.22 - @patternfly/react-table@4.111.5 - @patternfly/react-topology@4.88.27 - @patternfly/react-virtualized-extension@4.88.27
* chore(docs): Release notes 2022.13 * release note updates * add screnshots and versions * update note * updates from comments Co-authored-by: Titani <tlabaj@redaht.com>
- @patternfly/react-docs@5.102.33
Co-authored-by: Titani <tlabaj@redaht.com>
- @patternfly/react-docs@5.102.34
…atternfly#8160) * chore(Banner): update tests to new react testing library standards * add additional test to test screenReaderText * replace toHaveTextContent with toBeInTheDocument matcher * add test to check for pf-u-screen-reader class
- @patternfly/react-catalog-view-extension@4.92.28 - @patternfly/react-code-editor@4.82.28 - @patternfly/react-console@4.92.28 - @patternfly/react-core@4.250.3 - @patternfly/react-docs@5.102.35 - @patternfly/react-inline-edit-extension@4.86.29 - demo-app-ts@4.202.9 - @patternfly/react-log-viewer@4.87.23 - @patternfly/react-table@4.111.6 - @patternfly/react-topology@4.88.28 - @patternfly/react-virtualized-extension@4.88.28
- @patternfly/react-catalog-view-extension@4.92.29 - @patternfly/react-code-editor@4.82.29 - @patternfly/react-console@4.92.29 - @patternfly/react-core@4.250.4 - @patternfly/react-docs@5.102.36 - @patternfly/react-inline-edit-extension@4.86.30 - demo-app-ts@4.202.10 - @patternfly/react-log-viewer@4.87.24 - @patternfly/react-table@4.111.7 - @patternfly/react-topology@4.88.29 - @patternfly/react-virtualized-extension@4.88.29
…tternfly#8142) * fix(Dropdown next): Add support for forward ref and updated docs. * hide inner ref prop * hide innerRef Co-authored-by: Titani <tlabaj@redaht.com>
- @patternfly/react-catalog-view-extension@4.92.30 - @patternfly/react-code-editor@4.82.30 - @patternfly/react-console@4.92.30 - @patternfly/react-core@4.250.5 - @patternfly/react-docs@5.102.37 - @patternfly/react-inline-edit-extension@4.86.31 - demo-app-ts@4.202.11 - @patternfly/react-log-viewer@4.87.25 - @patternfly/react-table@4.111.8 - @patternfly/react-topology@4.88.30 - @patternfly/react-virtualized-extension@4.88.30
* chore(Title): update tests to new RTL standards * chore(Title): update tests to new RTL standards * chore(Title): update tests to new RTL standards Co-authored-by: Drew Amunategui II <drewamunateguiii@drews-mbp.acasmart.jh.edu> Co-authored-by: Drew Amunategui II <drewamunateguiii@Drews-MacBook-Pro.local>
- @patternfly/react-catalog-view-extension@4.92.31 - @patternfly/react-code-editor@4.82.31 - @patternfly/react-console@4.92.31 - @patternfly/react-core@4.250.6 - @patternfly/react-docs@5.102.38 - @patternfly/react-inline-edit-extension@4.86.32 - demo-app-ts@4.202.12 - @patternfly/react-log-viewer@4.87.26 - @patternfly/react-table@4.111.9 - @patternfly/react-topology@4.88.31 - @patternfly/react-virtualized-extension@4.88.31
…ly#8161) * docs(Empty state): Added EmptyStatePrimary to documentation * fix typo Co-authored-by: Titani <tlabaj@redaht.com>
- @patternfly/react-catalog-view-extension@4.92.32 - @patternfly/react-code-editor@4.82.32 - @patternfly/react-console@4.92.32 - @patternfly/react-core@4.250.7 - @patternfly/react-docs@5.102.39 - @patternfly/react-inline-edit-extension@4.86.33 - demo-app-ts@4.202.13 - @patternfly/react-log-viewer@4.87.27 - @patternfly/react-table@4.111.10 - @patternfly/react-topology@4.88.32 - @patternfly/react-virtualized-extension@4.88.32
33ee401
to
5860111
Compare
What: Closes #8091