fix(Form): Do not add any class if action modifier is missing

[karelhala]

Fixes currently broken master, because there is no info modifier for FormGroup.

[patternfly-build]

PatternFly-React preview: https://792-pr-patternfly-react-patternfly.surge.sh

[dmiller9911]

I missed this in the last review. it would probably be better to just use styles.modifiers.action

Suggested change

	const customClassName = css(styles.formGroup, getModifier(styles, 'action'), className);
	const customClassName = css(styles.formGroup, styles.modifiers.action, className);

This would allow the babel plugin to throw at build time if this is ever modified. getModifier should only be used if the modifier is coming in via props.

[rvsia]

@karelhala Thanks for fixing this! 👍 🙏

Optional, Nit/ we can remove classes for styles and write them in-line

<div {...props} className={css(styles.formGroup, styles.modifiers.action, className)}> {isHorizontal ? <div className={css(styles.formHorizontalGroup)}>{children}</div> : children} </div>

[dmiller9911]

@karelhala do you mind modifying this line too:
https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-4/react-core/package.json#L38

it should be yarn build:babel && yarn build:ts the ; currently allows the script to continue on an error which is allowing failed builds to get published.

[coveralls]

Pull Request Test Coverage Report for Build 2672

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 81.136%

---

Totals
Change from base Build 2668:	0.0%
Covered Lines:	3435
Relevant Lines:	3989

---

💛 - Coveralls

[jschuler]

#797 addressed some of these issues as well. We can use this PR to make the change to not use getModifier in the cases where modifier is not coming in via prop

[karelhala]

@ALL sorry for the late response, I like that you merged #797! I've updated this PR not to use getModifiers function and just straigh modifier from styles.