Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF4 Modal: Add missing modal typings #586

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

dlabrecq
Copy link
Member

Add missing modal typings to PF4.

Fixes: #581

Copy link
Contributor

@dmiller9911 dmiller9911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgutride dgutride merged commit 80c2b83 into patternfly:master Aug 31, 2018
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this pull request Sep 5, 2018
affects: @patternfly/react-core

Force react-core release to add missing modal typings

ISSUES CLOSED: patternfly#586
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this pull request Sep 5, 2018
affects: @patternfly/react-core

Force react-core release to add missing modal typings

ISSUES CLOSED: patternfly#586
dgutride pushed a commit that referenced this pull request Sep 5, 2018
affects: @patternfly/react-core

Force react-core release to add missing modal typings

ISSUES CLOSED: #586
@dlabrecq dlabrecq deleted the modal-typings branch June 25, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants