Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling back button in Wizard.Pattern. Fixes #527 #529

Merged
merged 1 commit into from
Aug 30, 2018

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Aug 10, 2018

What: #527 and #526

Add new property previousStepDisabled to Wizard.Pattern which disables/enables back steps

Link to Storybook:

Additional issues:

@coveralls
Copy link

coveralls commented Aug 10, 2018

Pull Request Test Coverage Report for Build 2005

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 78.457%

Totals Coverage Status
Change from base Build 2002: 0.009%
Covered Lines: 2851
Relevant Lines: 3387

💛 - Coveralls

@rawagner rawagner force-pushed the disable_back branch 2 times, most recently from 5851be4 to e73a6e3 Compare August 10, 2018 12:43
@jeff-phillips-18
Copy link
Member

Changes LGTM. Please use yarn commit and rebase.

@rawagner
Copy link
Contributor Author

@jeff-phillips-18 sorry for the late response, i was on PTO. The PR is now rebased and I also used yarn commit

@priley86
Copy link
Member

slightly conflicts w/ #555 ... I don't have any issue though.

@jeff-phillips-18
Copy link
Member

@rawagner Could you please rebase?

@rawagner
Copy link
Contributor Author

@jeff-phillips-18 rebased

@jeff-phillips-18 jeff-phillips-18 merged commit 529eeeb into patternfly:master Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants