-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling back button in Wizard.Pattern. Fixes #527 #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2005
💛 - Coveralls |
rawagner
force-pushed
the
disable_back
branch
2 times, most recently
from
August 10, 2018 12:43
5851be4
to
e73a6e3
Compare
Changes LGTM. Please use |
@jeff-phillips-18 sorry for the late response, i was on PTO. The PR is now rebased and I also used yarn commit |
jeff-phillips-18
previously approved these changes
Aug 22, 2018
slightly conflicts w/ #555 ... I don't have any issue though. |
@rawagner Could you please rebase? |
…d.Pattern affects: patternfly-react ISSUES CLOSED: patternfly#526 patternfly#527
@jeff-phillips-18 rebased |
jeff-phillips-18
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: #527 and #526
Add new property previousStepDisabled to Wizard.Pattern which disables/enables back steps
Link to Storybook:
Additional issues: