Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-icons): Added Initial Icons Package #453

Merged

Conversation

dmiller9911
Copy link
Contributor

affects: @patternfly/react-icons, @patternfly/react-docs

Added Icons package.

ISSUES CLOSED: #442

<div
key={id}
className={css(
styles.gridItem,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the Gallery PR is merged a PR for Grid will be opened. After that is merged this can be converted to use it.

@dmiller9911 dmiller9911 added the PF4 label Jul 3, 2018
@coveralls
Copy link

coveralls commented Jul 3, 2018

Pull Request Test Coverage Report for Build 1675

  • 18 of 18 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 74.675%

Totals Coverage Status
Change from base Build 1662: 0.2%
Covered Lines: 2122
Relevant Lines: 2619

💛 - Coveralls

@dmiller9911 dmiller9911 force-pushed the react-icons/initial-icons branch 2 times, most recently from c8083c5 to 414841d Compare July 4, 2018 19:43
@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 4, 2018

Deploy preview for patternfly-react ready!

Built with commit b8d99bb

https://deploy-preview-453--patternfly-react.netlify.com

dgutride
dgutride previously approved these changes Jul 5, 2018
@dmiller9911 dmiller9911 dismissed stale reviews from jeff-phillips-18 and dgutride via cef813e July 5, 2018 18:32
@dmiller9911 dmiller9911 force-pushed the react-icons/initial-icons branch 2 times, most recently from cef813e to b8d99bb Compare July 5, 2018 20:16
affects: @patternfly/react-icons, @patternfly/react-docs

Added Icons package.

ISSUES CLOSED: patternfly#442
@dmiller9911 dmiller9911 force-pushed the react-icons/initial-icons branch from b8d99bb to 3fbacc2 Compare July 5, 2018 20:25
@priley86
Copy link
Member

priley86 commented Jul 6, 2018

this is fortAwesome @dmiller9911 ! So per our discussion, when PF Next adds a new icon, we simply have to update the icons.js file and trigger a publish to get automated integration w/ React. Very nice ⭐️ !

I don't think beyond styling the color/sizes we'd need much customization of the SVG, but in the future, it might be fun to also explore other SVG -> React generators for more complex uses.

https://savage.now.sh/
https://github.com/soska/savagejsx
https://github.com/smooth-code/svgr

const closeIcon = <Icon name="times" />;
```

For a list of the available icons please refer to the [PatternFly React Docs](https://patternfly-react.netlify.com/styles/icons)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please confirm this link exists after merge 🙏

@jeff-phillips-18 jeff-phillips-18 merged commit fdbe746 into patternfly:master Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants