-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-icons): Added Initial Icons Package #453
feat(react-icons): Added Initial Icons Package #453
Conversation
<div | ||
key={id} | ||
className={css( | ||
styles.gridItem, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the Gallery PR is merged a PR for Grid will be opened. After that is merged this can be converted to use it.
Pull Request Test Coverage Report for Build 1675
💛 - Coveralls |
c8083c5
to
414841d
Compare
Deploy preview for patternfly-react ready! Built with commit b8d99bb |
cef813e
cef813e
to
b8d99bb
Compare
affects: @patternfly/react-icons, @patternfly/react-docs Added Icons package. ISSUES CLOSED: patternfly#442
b8d99bb
to
3fbacc2
Compare
this is fortAwesome @dmiller9911 ! So per our discussion, when PF Next adds a new icon, we simply have to update the icons.js file and trigger a publish to get automated integration w/ React. Very nice ⭐️ ! I don't think beyond styling the color/sizes we'd need much customization of the SVG, but in the future, it might be fun to also explore other SVG -> React generators for more complex uses. https://savage.now.sh/ |
const closeIcon = <Icon name="times" />; | ||
``` | ||
|
||
For a list of the available icons please refer to the [PatternFly React Docs](https://patternfly-react.netlify.com/styles/icons) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please confirm this link exists after merge 🙏
affects: @patternfly/react-icons, @patternfly/react-docs
Added Icons package.
ISSUES CLOSED: #442