Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-core/card): added Card Components #443

Closed
wants to merge 1 commit into from

Conversation

dmiller9911
Copy link
Contributor

affects: @patternfly/react-core, @patternfly/react-docs

Added Card, CardHeader, CardBody, and CardFooter components

ISSUES CLOSED: #386

@coveralls
Copy link

coveralls commented Jun 28, 2018

Pull Request Test Coverage Report for Build 1673

  • 25 of 25 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 74.648%

Totals Coverage Status
Change from base Build 1662: 0.2%
Covered Lines: 2129
Relevant Lines: 2626

💛 - Coveralls

@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 29, 2018

Deploy preview for patternfly-react ready!

Built with commit c43e41b

https://deploy-preview-443--patternfly-react.netlify.com

]}
/>
<Page
title="Patternfly React"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PatternFly casing on the title..

@priley86 priley86 requested review from a team and dgutride June 29, 2018 13:38
@priley86
Copy link
Member

Was looking for Card.test.js but i don't see it...

@dmiller9911
Copy link
Contributor Author

@Pattrick nothing to test so far really would just be a throwaway. I will add one to verify extra props are passed through. That should keep that from breaking.

@jgiardino
Copy link
Collaborator

Just wanted to mention patternfly/patternfly#430 here.

Currently, the Card is implemented with <div> elements, but ideally, the consumer should be able to specify more semantic elements, which might vary depending on context. This issue mentions <article> in the description, and then there are a few more cases that I listed in a comment. I would expect the react component to allow the consumer to choose which of these variations they want.

I'm not sure if you want to go ahead and update the react component based on changes expected to the core html component, or not, but wanted to make sure you were aware of this expectation.

@dmiller9911
Copy link
Contributor Author

I pushed up a change to allow users to pass in their own "components", which includes HTML elements. I followed the suggestion from that issue. If we need to make additional changes later we can. We could possibly even lockdown, with warnings, which elements are allowed if we make a list.

affects: @patternfly/react-core, @patternfly/react-docs

Added Card, CardHeader, CardBody, and CardFooter components

ISSUES CLOSED: patternfly#386
Copy link
Member

@dgutride dgutride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component looks good, follows pf4 styling

@jeff-phillips-18
Copy link
Member

I would be better to keep PRs limited to the intent and not include additional changes. I see changes to Title and other things that don't necessarily pertain to the card component.

@dmiller9911 dmiller9911 closed this Jul 5, 2018
@dmiller9911
Copy link
Contributor Author

@jeff-phillips-18, while it looks like these, are unrelated...they are not. The upgrade of patternfly-next caused all the snapshot updates and forced the title size updates. The docs navigation is due to the fact that Card is the first component with multiple components. I needed to filter out the secondary components. I have closed and will piece these together as separate PR's though.

@jeff-phillips-18
Copy link
Member

OK, gotcha @dmiller9911. Sorry, we could have proceeded then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants