-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-core/card): added Card Components #443
Conversation
Pull Request Test Coverage Report for Build 1673
💛 - Coveralls |
Deploy preview for patternfly-react ready! Built with commit c43e41b |
aa63983
to
e7618f9
Compare
]} | ||
/> | ||
<Page | ||
title="Patternfly React" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PatternFly
casing on the title..
Was looking for |
@Pattrick nothing to test so far really would just be a throwaway. I will add one to verify extra props are passed through. That should keep that from breaking. |
e7618f9
to
93bf71f
Compare
Just wanted to mention patternfly/patternfly#430 here. Currently, the Card is implemented with I'm not sure if you want to go ahead and update the react component based on changes expected to the core html component, or not, but wanted to make sure you were aware of this expectation. |
93bf71f
to
494ca4b
Compare
I pushed up a change to allow users to pass in their own "components", which includes HTML elements. I followed the suggestion from that issue. If we need to make additional changes later we can. We could possibly even lockdown, with warnings, which elements are allowed if we make a list. |
494ca4b
to
7e7b309
Compare
affects: @patternfly/react-core, @patternfly/react-docs Added Card, CardHeader, CardBody, and CardFooter components ISSUES CLOSED: patternfly#386
7e7b309
to
c43e41b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
component looks good, follows pf4 styling
I would be better to keep PRs limited to the intent and not include additional changes. I see changes to Title and other things that don't necessarily pertain to the card component. |
@jeff-phillips-18, while it looks like these, are unrelated...they are not. The upgrade of patternfly-next caused all the snapshot updates and forced the title size updates. The docs navigation is due to the fact that Card is the first component with multiple components. I needed to filter out the secondary components. I have closed and will piece these together as separate PR's though. |
OK, gotcha @dmiller9911. Sorry, we could have proceeded then. |
affects: @patternfly/react-core, @patternfly/react-docs
Added Card, CardHeader, CardBody, and CardFooter components
ISSUES CLOSED: #386