-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Table): reverts unnecessary fix #1623
Conversation
PatternFly-React preview: https://1623-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #1623 +/- ##
==========================================
+ Coverage 82.87% 82.89% +0.01%
==========================================
Files 573 573
Lines 6255 6249 -6
Branches 75 75
==========================================
- Hits 5184 5180 -4
+ Misses 1041 1039 -2
Partials 30 30
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1623 +/- ##
==========================================
+ Coverage 82.87% 82.89% +0.01%
==========================================
Files 573 573
Lines 6255 6249 -6
Branches 75 75
==========================================
- Hits 5184 5180 -4
+ Misses 1041 1039 -2
Partials 30 30
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add back the handling for where null and undefined are the values for curr.
This should be already handled (I just tested it for null/undefined) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I see what you did.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#1520 already fixed #1371 with some other enhacements.
#1621 reverted these enhacements, so this PR reverts that PR
It also added
which I do not think is necessary, because there are multiple use cases when the row is represented as structured data and we render that data according to that and do not render cells. In this use case, I think it is not necessary to show warnings (especially one per each cell).