Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): reverts unnecessary fix #1623

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

atiratree
Copy link

#1520 already fixed #1371 with some other enhacements.

#1621 reverted these enhacements, so this PR reverts that PR

It also added

`console.warn(`Cell value at [ ${rowKey}, ${key} ] should not be set to ${curr}`);` 

which I do not think is necessary, because there are multiple use cases when the row is represented as structured data and we render that data according to that and do not render cells. In this use case, I think it is not necessary to show warnings (especially one per each cell).

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1623-pr-patternfly-react-patternfly.surge.sh

@codecov-io
Copy link

Codecov Report

Merging #1623 into master will increase coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
+ Coverage   82.87%   82.89%   +0.01%     
==========================================
  Files         573      573              
  Lines        6255     6249       -6     
  Branches       75       75              
==========================================
- Hits         5184     5180       -4     
+ Misses       1041     1039       -2     
  Partials       30       30
Flag Coverage Δ
#patternfly3 84.75% <ø> (ø) ⬆️
#patternfly4 79.58% <83.33%> (+0.03%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ternfly-4/react-table/src/components/Table/Body.js 95.65% <83.33%> (+5.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d40f11...2835d07. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #1623 into master will increase coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
+ Coverage   82.87%   82.89%   +0.01%     
==========================================
  Files         573      573              
  Lines        6255     6249       -6     
  Branches       75       75              
==========================================
- Hits         5184     5180       -4     
+ Misses       1041     1039       -2     
  Partials       30       30
Flag Coverage Δ
#patternfly3 84.75% <ø> (ø) ⬆️
#patternfly4 79.58% <83.33%> (+0.03%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ternfly-4/react-table/src/components/Table/Body.js 95.65% <83.33%> (+5.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d40f11...2835d07. Read the comment docs.

Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add back the handling for where null and undefined are the values for curr.

@atiratree
Copy link
Author

Please add back the handling for where null and undefined are the values for curr.

This should be already handled (I just tested it for null/undefined)

Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I see what you did.

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 83165c5 into patternfly:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PF4 Table: Cannot read property 'title' of null
6 participants