Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): Do not return value if table is not collapsed #1272

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

karelhala
Copy link
Contributor

What:
When row is not collapsed do not pass value down so other props will not be effected by this object. This helps to prevent accidental title on first cell.

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1272-pr-patternfly-react-patternfly.surge.sh

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4176

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.31%

Totals Coverage Status
Change from base Build 4171: 0.0%
Covered Lines: 4555
Relevant Lines: 5334

💛 - Coveralls

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabaj dlabaj merged commit fe8c13c into patternfly:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants