fix(BadgedResource): don't restrict resourceName to a string #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://1260-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 4148
💛 - Coveralls |
| @@ -99,7 +99,7 @@ BadgedResource.propTypes = { | |||
| /** Full name of the resource kind to display in the badge tooltip and for screen readers (defaulted if valid resourceKind is given) */ | |||
| kindStr: PropTypes.string, | |||
| /** Name of the resource */ | |||
| resourceName: PropTypes.string, | |||
| resourceName: PropTypes.node, | |||
There was a problem hiding this comment.
While type node will accept a string, we typically use PropTypes.oneOfType([PropTypes.string, PropTypes.node]) to make it more clear.
lizagilman
force-pushed
the
badgedResource-fix
branch
from
afd3881 to
298d673
Compare
|
Thanks @jeff-phillips-18 , updated. |
jeff-phillips-18
approved these changes
Jan 28, 2019
kmcfaul
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: A fix following discussion on #1238