fix(Table): Use direct imports instead of spread #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://1237-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 4175
💛 - Coveralls |
jschuler
previously approved these changes
Jan 24, 2019
kmcfaul
previously approved these changes
Jan 24, 2019
tlabaj
previously approved these changes
Jan 24, 2019
tlabaj
reviewed
Jan 24, 2019
|
Fyi the reason for this is that the styles plugin only exports a default object. This might be a good candidate for a lint rule since it has happened before. |
karelhala
dismissed stale reviews from tlabaj, kmcfaul, ibolton336, and jschuler
via
f4a260d
karelhala
force-pushed
the
update-pf4-table-direct-imports
branch
3 times, most recently
from
f2e5824 to
61173b7
Compare
jschuler
previously approved these changes
Jan 25, 2019
karelhala
force-pushed
the
update-pf4-table-direct-imports
branch
from
3685e14 to
17466be
Compare
jharting
previously approved these changes
Jan 28, 2019
karelhala
force-pushed
the
update-pf4-table-direct-imports
branch
from
038c4bf to
33ad211
Compare
kmcfaul
approved these changes
Jan 29, 2019
jharting
approved these changes
Jan 30, 2019
dgutride
pushed a commit
that referenced
this pull request
Jan 31, 2019
* fix(Table): Use direct imports instead of spread (#1237) * fix(Table): Use direct imports instead of spread * Do not show selects for collapsed rows * chore(release): releasing packages - patternfly4-react-lerna-root@1.42.4 - @patternfly/react-docs@3.21.13 - @patternfly/react-table@0.4.13 * fix(AboutModal): Use paragraph in heading (#1280) In PF core heading types of AboutModal were updated. This PR updates PF react with those changes. Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com> * chore(release): releasing packages - patternfly4-react-lerna-root@1.42.5 - @patternfly/react-core@1.51.4 - @patternfly/react-docs@3.21.14 - @patternfly/react-integration@1.0.12 - @patternfly/react-table@0.4.14 * Updated with core 167 updates * Fixed broken unit test and updated base.css to include pficon * Reverting the old toolbar. * Added Toolbar Layout Back. * Reverted Layout. * fix(styles): add toolbar css back to layout temporarily * fix(packages): add correct css include * fix(css): update css file * fix(import): move to tablecss * fix(grid): add grid style modifier * sort button * rebase changes and console log * fix(table): updated table * fix(toolbar): trying to fix toolbar again * snapshots
dgutride
pushed a commit
to dgutride/patternfly-react
that referenced
this pull request
Feb 1, 2019
* fix(Table): Use direct imports instead of spread (patternfly#1237) * fix(Table): Use direct imports instead of spread * Do not show selects for collapsed rows * chore(release): releasing packages - patternfly4-react-lerna-root@1.42.4 - @patternfly/react-docs@3.21.13 - @patternfly/react-table@0.4.13 * fix(AboutModal): Use paragraph in heading (patternfly#1280) In PF core heading types of AboutModal were updated. This PR updates PF react with those changes. Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com> * chore(release): releasing packages - patternfly4-react-lerna-root@1.42.5 - @patternfly/react-core@1.51.4 - @patternfly/react-docs@3.21.14 - @patternfly/react-integration@1.0.12 - @patternfly/react-table@0.4.14 * Updated with core 167 updates * Fixed broken unit test and updated base.css to include pficon * Reverting the old toolbar. * Added Toolbar Layout Back. * Reverted Layout. * fix(styles): add toolbar css back to layout temporarily * fix(packages): add correct css include * fix(css): update css file * fix(import): move to tablecss * fix(grid): add grid style modifier * sort button * rebase changes and console log * fix(table): updated table * fix(toolbar): trying to fix toolbar again * snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
When using react table there is tons of warnings due to missing exports in patternfly next styles. That is caused by using spread instead of default import. It is much safer (but a bit less readable) to use direct imports.
Allow first row to be collapsible by checking undefined instead of casting Boolean.
Do not show select in collapsed child unless show checkbox is engorced on row.