Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chip component #1180

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Chip component #1180

merged 1 commit into from
Jan 15, 2019

Conversation

ibolton336
Copy link
Member

What:
closes #976

Additional issues:

@ibolton336 ibolton336 added the PF4 label Jan 14, 2019
@coveralls
Copy link

coveralls commented Jan 14, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 3976

  • 8 of 16 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 80.016%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/patternfly-4/react-core/src/components/Chip/Chip.js 4 12 33.33%
Totals Coverage Status
Change from base Build 3974: -0.1%
Covered Lines: 4401
Relevant Lines: 5161
💛 - Coveralls

@ibolton336 ibolton336 mentioned this pull request Jan 14, 2019
Closed
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1180-pr-patternfly-react-patternfly.surge.sh

@ibolton336 ibolton336 force-pushed the chip-component branch 4 times, most recently from 5f36bf6 to 30bd4b2 Compare January 15, 2019 14:56
@boaz0 @ibolton336
feat(Chip): Add the Chip component to PF4
be5572c 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
tlabaj
tlabaj approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jschuler jschuler merged commit 752adae into patternfly:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschuler jschuler jschuler left review comments

@tlabaj tlabaj tlabaj approved these changes

@dlabaj dlabaj dlabaj approved these changes

@priley86 priley86 Awaiting requested review from priley86

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chip
7 participants
@ibolton336 @coveralls @patternfly-build @jschuler @dlabaj @tlabaj @boaz0