fix(DualList): de-Select items after the transition between lists. #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://1178-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 3960
💛 - Coveralls |
dtaylor113
previously approved these changes
Jan 14, 2019
| @@ -38,22 +38,34 @@ export const makeAllItemsVisible = list => | |||
| export const sortItems = (items, sortFactor = 'label') => | |||
| items.sort((a, b) => (a[sortFactor].toLowerCase() > b[sortFactor].toLowerCase() ? 1 : -1)); | |||
|
|
|||
| export const arrangeArray = ({ items, sortBy, isSortAsc = true, isMainChecked = false }) => { | |||
| export const shouldItemBeChecked = ({ item, resetAllSelected, isMainChecked }) => { | |||
There was a problem hiding this comment.
why take a object with three fields rather than 3 parameters?
There was a problem hiding this comment.
oops, copy-pasted it from another function signature with a lot of properties,
I don't mind changing it,
btw from what number of arguments do we usually provide objects instead?
There was a problem hiding this comment.
I'm not sure we ever should in helper functions
There was a problem hiding this comment.
no problem, opening a PR to refactor that.
There was a problem hiding this comment.
Added the refactor PR now
Ron-Lavi
force-pushed
the
fix/dual-list-selected-items
branch
from
74f6778 to
88271b5
Compare
dtaylor113
approved these changes
Jan 15, 2019
jeff-phillips-18
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After items were moved between the lists,
they should not be selected as specified in the design.