fix(ModalContent): Hide footer when no actions #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show the footer only if the actions array has content. Also made some adjustments to ModalContent.test.js since some snapshots were blank, one test had a typo, and some tests used a deprecated footer prop. Fixes #1107
Pull Request Test Coverage Report for Build 3916
💛 - Coveralls |
dlabaj
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted ModalContent so it only shows the footer if the actions array has content. I also made some
adjustments to ModalContent.test.js since some snapshots were blank, one
test had a typo, and some tests used what seems to be a deprecated footer prop.
Fixes #1107.