Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dropdown): set default button type to button #1148

Merged
merged 1 commit into from
Jan 9, 2019
Merged

fix(Dropdown): set default button type to button #1148

merged 1 commit into from
Jan 9, 2019

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Jan 8, 2019

What: Changed Dropdown button types to default to type='button'. Providing a type manually will overwrite the default.

References issue: #1105

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1148-pr-patternfly-react-patternfly.surge.sh

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3853

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 81.247%
Totals Coverage Status
Change from base Build 3852: 0.01%
Covered Lines: 4367
Relevant Lines: 5072
💛 - Coveralls

@tlabaj tlabaj merged commit b4bded3 into patternfly:master Jan 9, 2019
@kmcfaul kmcfaul mentioned this pull request Jan 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlabaj tlabaj tlabaj approved these changes

@dlabaj dlabaj dlabaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kmcfaul @patternfly-build @coveralls @dlabaj @tlabaj