fix(modal): rename reactRoot to srHide and add to ts file #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlabaj
previously approved these changes
Dec 19, 2018
tlabaj
reviewed
Dec 19, 2018
dgutride
previously approved these changes
Dec 19, 2018
dlabrecq
reviewed
Dec 19, 2018
| /** React application root element */ | ||
| reactRoot: PropTypes.instanceOf(safeHTMLElement).isRequired | ||
| /** The parent element container to hide from screen-reader applications when the modal is open */ | ||
| srHide: PropTypes.instanceOf(safeHTMLElement).isRequired |
There was a problem hiding this comment.
Can we please remove the isRequired?
| @@ -14,7 +14,7 @@ class SimpleModal extends React.Component { | |||
|
|
|||
| render() { | |||
| const { isModalOpen } = this.state; | |||
| const reactRoot = typeof document !== 'undefined' ? document.querySelector('#___gatsby') : ''; | |||
| const srHide = typeof document !== 'undefined' ? document.querySelector('#___gatsby') : ''; | |||
There was a problem hiding this comment.
As an app developer, it's not clear what I should use in place of the '#___gatsby' selector. It would be helpful to add a comment in this example describing what I should use instead.
| @@ -9,6 +9,7 @@ export interface ModalProps extends HTMLProps<HTMLDivElement> { | |||
| isOpen?: boolean; | |||
| onClose?: Function; | |||
| title: string; | |||
| srHide: Element; | |||
There was a problem hiding this comment.
Can we please make srHide optional?
Not sure why this worked during my test if it's not optional? That is, I didn't provide an srHide property.
|
PatternFly-React preview: https://1098-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 3679
💛 - Coveralls |
|
@tlabaj from what i can see About Modal does not apply aria-hidden (yet) |
tlabaj
previously approved these changes
Dec 19, 2018
dlabrecq
approved these changes
Dec 19, 2018
tlabaj
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.