fix(pf3): fix usage of noop in BulletChart

[jschuler]

Previous travis build was failing because helpers.noop was undefined. I could reproduce this locally. We can import just noop and use that instead.

[patternfly-build]

PatternFly-React preview: https://1083-pr-patternfly-react-patternfly.surge.sh

[jeff-phillips-18]

why is it failing? helpers.noop should be defined.

https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/patternfly-react/src/common/helpers.js#L98-L120

[coveralls]

Pull Request Test Coverage Report for Build 3629

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+3.8%) to 82.057%

---

Totals
Change from base Build 3626:	3.8%
Covered Lines:	4269
Relevant Lines:	4919

---

💛 - Coveralls

[jschuler]

@jeff-phillips-18

[jschuler]

btw, I am not sure why it thinks the failure is in DualList, i see that the test is mocking common/helpers, wonder if that is related. Regardless, since BulletChart is only using noop it is anyways cleaner to just import that

[jeff-phillips-18]

Ah, DualList tests are redefining helpers which causes it to lose the noop function. This is a quick fix but likely not the correct fix as it will probably come back to bite us again.

[jeff-phillips-18]

...sigh

[jschuler]

@jeff-phillips-18 I agree, at least this should get the build passing again. Let's put a proper fix in for the issue with DualList test redefining common helpers

[jschuler]

@jeff-phillips-18 Created an issue here
#1085

[jeff-phillips-18]

Thanks @jschuler