-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(BulletChart): Add Thresholds to Legend #1074
Conversation
PatternFly-React preview: https://1074-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 3606
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks, Jeff!
I'm a little confused. Should the bar turn orange and/or red when over Warning or Error thresholds...like the arc does in gauge charts? |
No, the bar remains the same. The threshold lines are used as indicators. See https://www.patternfly.org/pattern-library/data-visualization/bullet-chart/#design |
Just concerned, because on that page it has: What denotes ''poor, good, excellent" for the bars? |
That would be up to the application to decide. That text is meant for the range bars. |
Provides the ability to add Threshold items to the legend if either text or a function is provided.