Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SimpleSelect,CheckboxSelect): Handle initial selection(s) #10734

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

jeff-phillips-18
Copy link
Member

What:
Closes #10732

Description:
Handle initial selected options and options that get updated.

@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 15, 2024

Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CheckboxSelect and SimpleSelect support and display initial selections, onSelect functionality works as expected

@dlabaj dlabaj merged commit 3b857f8 into patternfly:main Jul 15, 2024
13 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the simple-select-fix branch July 15, 2024 18:44
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-docs@6.4.0-prerelease.35
  • @patternfly/react-templates@1.1.0-prerelease.24

Thanks for your contribution! 🎉

tlabaj pushed a commit to tlabaj/patternfly-react that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Select templates - Initial state for the select components are not shown.
4 participants