Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Drag and drop): Updated example for multi list to use flex #10692

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Jul 2, 2024

Updated example for multi list to use flex so that target list will maintain size when empty

What: Closes #9749

Additional issues:

@tlabaj tlabaj requested review from mcoker, a team, wise-king-sullyman and kmcfaul and removed request for a team July 2, 2024 18:43
@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 2, 2024

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might just be testing it wrong somehow, but when I got to the preview link and move all of the items from the second list over to the first it still isn't letting me move them back?

Screen.Recording.2024-07-03.at.9.47.09.AM.mov

@tlabaj
Copy link
Contributor Author

tlabaj commented Jul 3, 2024

I might just be testing it wrong somehow, but when I got to the preview link and move all of the items from the second list over to the first it still isn't letting me move them back?

@wise-king-sullyman you are right. It only worked with the first item i dragged. I am investigating.

@kmcfaul
Copy link
Contributor

kmcfaul commented Jul 15, 2024

@tlabaj I'm seeing the same issue as @wise-king-sullyman but that's possibly because the build had failed, so I don't think the surge is updated yet.

Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There does seem to be an inconsistent issue after emptying one drop zone and starting to refill it, sometimes an item isn't shoved properly and overlaps with another item. There is also maybe an issue where if you drop an item on the bottom of the drop zone it will append to the beginning of the list instead of the end.

That said, this PR does fix the overall issue of the non-interactable empty dropzone and it is a deprecated component, so I'd probably be fine opening a follow up for these problems.

@wise-king-sullyman wise-king-sullyman merged commit ae4d6f3 into patternfly:main Jul 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Droppable - Empty Droppables do not receive Draggables
5 participants