Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(templates): patch release for templates #10676

Merged
merged 5 commits into from
Jul 2, 2024
Merged

feat(templates): patch release for templates #10676

merged 5 commits into from
Jul 2, 2024

Commits on Jun 27, 2024

  1. feat(Select): Typeahead template (patternfly#10235) 

    * fix(SelectTypeahead example): make "no results" option aria-disabled

* fix(SelectTypeahead example): don't close the menu on input click when there is text

* fix(SelectTypeahead example): remove visual focus on item after closing the menu

Prevents situation where we open the menu via focusing on the toggle arrow and clicking enter -- then two items can have focus styling, which is not ideal.

* fix(SelectTypeahead example): remove check icon from the selected option when input text changes

* fix(SelectTypeahead example): rename example

* feat(Select): add prop to opt out of focusing first menu item on open

Flag prop shouldFocusFirstMenuItemOnOpen has been added, because of typeahead select, which should keep focus on the input.

* refactor(SelectTypeahead example): adaption on first menu item focused

* feat(MenuToggle): make typeahead toggle button not focusable

* fix(SelectTypeahead example): focus input after toggle button click

* feat(SelectTypeahead example): change the focused item on hover

* fix(SelectTypeahead example): don't focus on first item after tabbing

* feat(Select): add typeahead select template

* fix(SelectTypeahead): address PR review

- new changes were done also based on SelectTypeahead example updates (patternfly#10207)

* fix(SelectTypeahead template): call onToggle every time menu opens/closes

* refactor(SelectTypeahead template)
    @adamviktora @kmcfaul
    adamviktora authored and kmcfaul committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    bf104b2 View commit details
    Browse the repository at this point in the history

  2. feat(Select): Typeahead example (patternfly#10207) 

    * refactor(Select): rename shouldFocusFirstMenuItemOnOpen

* feat(SelectTypeahead example): better arrow up/down keys handling

- does not apply visual focus on the first menu option
- handles disabled options
- opens menu on pressing up/down arrow keys

* feat(SelectTypeahead example): don't close menu on clicking clear button when open

* refactor(SelectTypeahead example)

* refactor(SelectTypeahead example)

* fix(SelectTypeaheadCreatable example): changes based on SelectTypeahead

* fix(SelectMultiTypeahead example): changes based on SelectTypeahead

* fix(SelectTypeaheadCreatable example): don't show create option if that exact option exists

* fix(SelectMultiTypeaheadCreatable): changes based on SelectTypeahead

* fix(SelectMultiTypeaheadCheckbox): changes based on SelectTypeahead

* fix(SelectTypeaheadCreatable): close menu after creating option

* fix(SelectTypeahead template): rename prop back to shouldFocusFirstItemOnOpen
    @adamviktora @kmcfaul
    adamviktora authored and kmcfaul committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    ed62ec2 View commit details
    Browse the repository at this point in the history

  3. feat(Dropdown): Added simple template (patternfly#10308) 

    * feat(Dropdown): Added simple template

* Added tests

* Added imports to example file

* Additional fixes for docs fail

* Updated import name

* Added additional tests
    @thatblindgeye @kmcfaul
    thatblindgeye authored and kmcfaul committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    47dcd5a View commit details
    Browse the repository at this point in the history

  4. feat(templates): toggle props & improvements (patternfly#10473) 

    * feat(templates): toggle props & improvements

* remove toggleContent from typeahead template

* update template names

* update tests

* added SimpleSelect tests

* fix yarnlock
    @kmcfaul
    kmcfaul committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    efd321e View commit details
    Browse the repository at this point in the history

  5. fix(): update demo-app version and snap

    @kmcfaul
    kmcfaul committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    c5b4fcc View commit details
    Browse the repository at this point in the history