Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc): Replace Text, TextContent, TextList and TextListItem with Content - PART 1 #10611

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

adamviktora
Copy link
Contributor

@adamviktora adamviktora commented Jun 13, 2024

What: Closes #10395, #10390

This is a PART 1, it is not a breaking change yet, see this comment.
Part 2 PR: #10643

Codemod PR: patternfly/pf-codemods#675
Org issue to replace Text: patternfly/patternfly-org#4087

(link to previous closed PR: #10579)

@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 13, 2024

@adamviktora adamviktora changed the title Replace Text, TextContent, TextList and TextListItem with Content feat(misc): Replace Text, TextContent, TextList and TextListItem with Content Jun 13, 2024
@adamviktora adamviktora force-pushed the text-to-content_API-update branch 3 times, most recently from 7922559 to d49a920 Compare June 20, 2024 11:56
@adamviktora adamviktora marked this pull request as ready for review June 20, 2024 11:57
@adamviktora adamviktora requested a review from tlabaj June 20, 2024 11:57
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update Content.tsx to export as Content, it's still being exported as Text and is referred to as Text in the docs and examples (including the imports and usage in examples). The examples should use Content instead of the Text suite (maybe keeping a couple Text-using examples if we are keeping the Text components around, but my impression was they were being removed?).

Do we want to remove TextContent, TextList, TextListItem or are we keeping them for now? Not a blocker if we want to keep them.

@adamviktora adamviktora changed the title feat(misc): Replace Text, TextContent, TextList and TextListItem with Content feat(misc): Replace Text, TextContent, TextList and TextListItem with Content - PART 1 Jun 26, 2024
@adamviktora
Copy link
Contributor Author

@kmcfaul
Sorry, I did not explain the intention in the description. So there will also be a part 2 PR: #10643 which removes the Text, TextContent, TextList and TextListItem.

The reason for doing the changes separately in two PRs is:

  1. To keep the correct version history of the files, so the changes are tracked as a rename rather than a new component (see this conversation)
  2. The second PR will break the build because updates are needed in org as well.

@adamviktora adamviktora requested a review from kmcfaul June 26, 2024 15:13
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@tlabaj tlabaj merged commit 9f49fad into patternfly:v6 Jul 1, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@6.0.0-alpha.74
  • @patternfly/react-core@6.0.0-alpha.74
  • @patternfly/react-docs@7.0.0-alpha.80
  • @patternfly/react-drag-drop@6.0.0-alpha.56
  • demo-app-ts@5.1.1-alpha.73
  • @patternfly/react-table@6.0.0-alpha.75
  • @patternfly/react-templates@6.0.0-alpha.24

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Text component name to Content to better align with core Text - support for hr element
6 participants