Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add rimraf to the root of the workspace #10275

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

jonkoops
Copy link
Contributor

Moves rimraf to the root of the workspace so that all packages can use it directly during development, as some are missing it as a dependency causing errors when using newer versions of Yarn or PNPM. This removes the need to specify the version for each package, which have grown inconsistent over time.

This PR also removes shx (a rimraf competitor), which was installed, but never used anywhere.

Needed to land #9959

@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 15, 2024

Signed-off-by: Jon Koops <jonkoops@gmail.com>
Copy link
Contributor

@mfrances17 mfrances17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved.

@mfrances17 mfrances17 requested a review from tlabaj April 15, 2024 20:10
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tlabaj tlabaj merged commit 4858010 into patternfly:main Apr 19, 2024
13 checks passed
@jonkoops jonkoops deleted the root-rimraf branch April 20, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants