Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Select): Typeahead template #10235

Merged
merged 15 commits into from
May 2, 2024
Merged

feat(Select): Typeahead template #10235

merged 15 commits into from
May 2, 2024

Commits on Apr 2, 2024

  1. fix(SelectTypeahead example): make "no results" option aria-disabled

    @adamviktora
    adamviktora committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    26a6217 View commit details
    Browse the repository at this point in the history

  2. fix(SelectTypeahead example): don't close the menu on input click whe… 

    …n there is text
    @adamviktora
    adamviktora committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    0d1a389 View commit details
    Browse the repository at this point in the history

  3. fix(SelectTypeahead example): remove visual focus on item after closi… 

    …ng the menu

Prevents situation where we open the menu via focusing on the toggle arrow and clicking enter -- then two items can have focus styling, which is not ideal.
    @adamviktora
    adamviktora committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    b79a223 View commit details
    Browse the repository at this point in the history

  4. fix(SelectTypeahead example): remove check icon from the selected opt… 

    …ion when input text changes
    @adamviktora
    adamviktora committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    5a50017 View commit details
    Browse the repository at this point in the history

  5. fix(SelectTypeahead example): rename example

    @adamviktora
    adamviktora committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    19ef8ec View commit details
    Browse the repository at this point in the history

  6. feat(Select): add prop to opt out of focusing first menu item on open 

    Flag prop shouldFocusFirstMenuItemOnOpen has been added, because of typeahead select, which should keep focus on the input.
    @adamviktora
    adamviktora committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c01f0f3 View commit details
    Browse the repository at this point in the history

  7. refactor(SelectTypeahead example): adaption on first menu item focused

    @adamviktora
    adamviktora committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    337b5c1 View commit details
    Browse the repository at this point in the history

  8. feat(MenuToggle): make typeahead toggle button not focusable

    @adamviktora
    adamviktora committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    87d9546 View commit details
    Browse the repository at this point in the history

  9. fix(SelectTypeahead example): focus input after toggle button click

    @adamviktora
    adamviktora committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    80a9699 View commit details
    Browse the repository at this point in the history

  10. feat(SelectTypeahead example): change the focused item on hover

    @adamviktora
    adamviktora committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    917ca79 View commit details
    Browse the repository at this point in the history

  11. fix(SelectTypeahead example): don't focus on first item after tabbing

    @adamviktora
    adamviktora committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    ec545d4 View commit details
    Browse the repository at this point in the history

  12. feat(Select): add typeahead select template

    @adamviktora
    adamviktora committed Apr 2, 2024
    3 Configuration menu
    Copy the full SHA
    bb7e7f8 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. fix(SelectTypeahead): address PR review 

    - new changes were done also based on SelectTypeahead example updates (patternfly#10207)
    @adamviktora
    adamviktora committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    dacd40d View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. fix(SelectTypeahead template): call onToggle every time menu opens/cl… 

    …oses
    @adamviktora
    adamviktora committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d148532 View commit details
    Browse the repository at this point in the history

  2. refactor(SelectTypeahead template)

    @adamviktora
    adamviktora committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9914996 View commit details
    Browse the repository at this point in the history