-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Label): penta updates #10037
Merged
Merged
feat(Label): penta updates #10037
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 53 additions & 20 deletions
73
packages/react-core/src/components/Label/examples/LabelCompact.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,60 @@ | ||
import React from 'react'; | ||
import { Label } from '@patternfly/react-core'; | ||
import { Label, Flex } from '@patternfly/react-core'; | ||
import InfoCircleIcon from '@patternfly/react-icons/dist/esm/icons/info-circle-icon'; | ||
|
||
export const LabelCompact: React.FunctionComponent = () => ( | ||
<React.Fragment> | ||
<Label isCompact>Grey</Label>{' '} | ||
<Label isCompact icon={<InfoCircleIcon />}> | ||
Compact icon | ||
</Label>{' '} | ||
<Label isCompact onClose={() => Function.prototype}> | ||
Compact removable | ||
</Label>{' '} | ||
<Label isCompact icon={<InfoCircleIcon />} onClose={() => Function.prototype}> | ||
Compact icon removable | ||
</Label>{' '} | ||
<Label isCompact href="#compact"> | ||
Compact link | ||
</Label>{' '} | ||
<Label isCompact href="#compact" onClose={() => Function.prototype}> | ||
Compact link removable | ||
</Label> | ||
<Label isCompact icon={<InfoCircleIcon />} onClose={() => Function.prototype} textMaxWidth="16ch"> | ||
Compact label with icon that overflows | ||
</Label> | ||
<Flex gap={{ default: 'gapSm' }}> | ||
<Label isCompact>Compact</Label> | ||
<Label isCompact icon={<InfoCircleIcon />}> | ||
Compact icon | ||
</Label> | ||
<Label isCompact onClose={() => Function.prototype}> | ||
Compact removable | ||
</Label> | ||
<Label isCompact icon={<InfoCircleIcon />} onClose={() => Function.prototype}> | ||
Compact icon removable | ||
</Label> | ||
<Label isCompact href="#compact"> | ||
Compact link | ||
</Label> | ||
<Label isCompact href="#compact" onClose={() => Function.prototype}> | ||
Compact link removable | ||
</Label> | ||
<Label isCompact icon={<InfoCircleIcon />} onClose={() => Function.prototype} textMaxWidth="16ch"> | ||
Compact label with icon that overflows | ||
</Label> | ||
</Flex> | ||
<br /> | ||
<Flex gap={{ default: 'gapSm' }}> | ||
<Label variant="outline" color="blue" isCompact> | ||
Compact | ||
</Label> | ||
<Label variant="outline" color="blue" isCompact icon={<InfoCircleIcon />}> | ||
Compact icon | ||
</Label> | ||
<Label variant="outline" color="blue" isCompact onClose={() => Function.prototype}> | ||
Compact removable | ||
</Label> | ||
<Label variant="outline" color="blue" isCompact icon={<InfoCircleIcon />} onClose={() => Function.prototype}> | ||
Compact icon removable | ||
</Label> | ||
<Label variant="outline" color="blue" isCompact href="#compact"> | ||
Compact link | ||
</Label> | ||
<Label variant="outline" color="blue" isCompact href="#compact" onClose={() => Function.prototype}> | ||
Compact link removable | ||
</Label> | ||
<Label | ||
variant="outline" | ||
color="blue" | ||
isCompact | ||
icon={<InfoCircleIcon />} | ||
onClose={() => Function.prototype} | ||
textMaxWidth="16ch" | ||
> | ||
Compact label with icon that overflows | ||
</Label> | ||
</Flex> | ||
</React.Fragment> | ||
); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please open codemod issue for this removed prop.