Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Drawer): consumed Penta updates #10036

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Conversation

thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented Jan 23, 2024

What: Closes #9979
Codemod: patternfly/pf-codemods#553

Additional issues:

@thatblindgeye thatblindgeye linked an issue Jan 23, 2024 that may be closed by this pull request
@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 23, 2024

@thatblindgeye thatblindgeye requested review from a team, wise-king-sullyman, mfrances17, andrew-ronaldson, lboehling and srambach and removed request for a team January 23, 2024 18:17
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code all looks good, will have to circle back to this when surge is back up and running to finish the review though.

One small thing I saw that I think needs updating.

Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work, thanks

Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a bug in core with the z-order, but this looks solid! 🗄️

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 4dba57a into patternfly:v6 Feb 1, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@6.0.0-alpha.26
  • @patternfly/react-core@6.0.0-alpha.26
  • @patternfly/react-docs@7.0.0-alpha.27
  • @patternfly/react-drag-drop@6.0.0-alpha.7
  • @patternfly/react-integration@6.0.0-alpha.14
  • demo-app-ts@5.1.1-alpha.25
  • @patternfly/react-table@6.0.0-alpha.26

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consume core Penta updates: Drawer
7 participants