Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 rebase #10033

Merged
merged 99 commits into from
Jan 25, 2024
Merged

V6 rebase #10033

merged 99 commits into from
Jan 25, 2024

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Jan 22, 2024

What: Closes #10032

Additional issues:

mcoker and others added 30 commits November 2, 2023 09:49
 - @patternfly/react-code-editor@5.2.0-prerelease.20
 - @patternfly/react-core@5.2.0-prerelease.20
 - @patternfly/react-docs@6.2.0-prerelease.20
 - demo-app-ts@5.1.1-prerelease.43
 - @patternfly/react-table@5.2.0-prerelease.20
* fix(Text input): Added aria-expanded

* add interface

* updates from review
…rawer item read state (patternfly#9569)

* fix(Notification Drawer): Added screen reader text for notification drawer item read state

* fix snapshot

* Update prop description

* add aria-live

* update snapshots
…y#9709)

* feat: ability to add props to WizardFooter buttons

* fix(WizardFooter): null check

* fix(Wizard): simpler design of adding footer buttons props

* test(Wizard): can add props to footer buttons

* docs(WizardFooter): move comment so docs have correct description

* refactor(WizardFooter): move FooterButtonProps to types file
* chore(Divider): update tests to new standards

* changes from PR review
 - @patternfly/react-code-editor@5.2.0-prerelease.21
 - @patternfly/react-core@5.2.0-prerelease.21
 - @patternfly/react-docs@6.2.0-prerelease.21
 - demo-app-ts@5.1.1-prerelease.44
 - @patternfly/react-table@5.2.0-prerelease.21
…es (patternfly#9347)

* bug(build): fixed built ESM files importing CJS files from react-styles

* edited yarn.lock to invalidate deps cache in GH actions

* excluded file extensions from react-styles path transform in ESM build

* updated jest config to transform .mjs files

* updated pr action to invalidate deps cache if package files added/edited

* chore(deps): Add ts-node to support executing typescript files directly
 - @patternfly/react-code-editor@5.2.0-prerelease.22
 - @patternfly/react-core@5.2.0-prerelease.22
 - @patternfly/react-docs@6.2.0-prerelease.22
 - demo-app-ts@5.1.1-prerelease.45
 - @patternfly/react-table@5.2.0-prerelease.22
 - transformer-react-styles-esm-imports@1.0.1-prerelease.0
…lease.4 (patternfly#9780)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 - @patternfly/react-charts@7.2.0-prerelease.6
 - @patternfly/react-code-editor@5.2.0-prerelease.23
 - @patternfly/react-core@5.2.0-prerelease.23
 - @patternfly/react-docs@6.2.0-prerelease.23
 - @patternfly/react-icons@5.2.0-prerelease.6
 - demo-app-ts@5.1.1-prerelease.46
 - @patternfly/react-styles@5.2.0-prerelease.4
 - @patternfly/react-table@5.2.0-prerelease.23
 - @patternfly/react-tokens@5.2.0-prerelease.5
…ly#9048 (patternfly#9087)

* feat(Datalist): implement full page Basic demo to match HTML patternfly#9048

* fix syntax error

* comments applied

* comments applied

* comments applied

* comments applied

* \xa0 comments applied

* move key per review comments

* address PR comments

* revert change to package.json

* Converted basic demo to TS

---------

Co-authored-by: nicolethoen <nthoen@redhat.com>
Co-authored-by: Eric Olkowski <thatblindgeye@gmail.com>
 - @patternfly/react-code-editor@5.2.0-prerelease.24
 - @patternfly/react-core@5.2.0-prerelease.24
 - @patternfly/react-docs@6.2.0-prerelease.24
 - demo-app-ts@5.1.1-prerelease.47
 - @patternfly/react-table@5.2.0-prerelease.24
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lease.5 (patternfly#9806)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 - @patternfly/react-charts@7.2.0-prerelease.7
 - @patternfly/react-code-editor@5.2.0-prerelease.25
 - @patternfly/react-core@5.2.0-prerelease.25
 - @patternfly/react-docs@6.2.0-prerelease.25
 - @patternfly/react-icons@5.2.0-prerelease.7
 - demo-app-ts@5.1.1-prerelease.48
 - @patternfly/react-styles@5.2.0-prerelease.5
 - @patternfly/react-table@5.2.0-prerelease.25
 - @patternfly/react-tokens@5.2.0-prerelease.6
 - @patternfly/react-code-editor@5.2.0-prerelease.26
 - @patternfly/react-core@5.2.0-prerelease.26
 - @patternfly/react-docs@6.2.0-prerelease.26
 - demo-app-ts@5.1.1-prerelease.49
 - @patternfly/react-table@5.2.0-prerelease.26
 - @patternfly/react-code-editor@5.2.0-prerelease.27
 - @patternfly/react-core@5.2.0-prerelease.27
 - @patternfly/react-docs@6.2.0-prerelease.27
 - demo-app-ts@5.1.1-prerelease.50
 - @patternfly/react-table@5.2.0-prerelease.27
* clean up instances of Array.apply

* rename item to value
 - @patternfly/react-code-editor@5.2.0-prerelease.28
 - @patternfly/react-core@5.2.0-prerelease.28
 - @patternfly/react-docs@6.2.0-prerelease.28
 - @patternfly/react-integration@5.1.1-prerelease.15
 - demo-app-ts@5.1.1-prerelease.51
 - @patternfly/react-table@5.2.0-prerelease.28
 - @patternfly/react-code-editor@5.2.0-prerelease.29
 - @patternfly/react-core@5.2.0-prerelease.29
 - @patternfly/react-docs@6.2.0-prerelease.29
 - @patternfly/react-icons@5.2.0-prerelease.8
 - demo-app-ts@5.1.1-prerelease.52
 - @patternfly/react-table@5.2.0-prerelease.29
* add spread prop test, update test

* chore(DataList): update tests

* fix merge error

* break out into separate files, pr feedback

* updates

* fix some example ids

* minor test updates

* revert action change
* bug(ClipboardCopy): change children type to string

Signed-off-by: gitdallas <dallas.nicol@gmail.com>

* fix clipboardcopyexpanded to work with string children

Signed-off-by: gitdallas <dallas.nicol@gmail.com>

* refactor a bit

* fix bad rebase

---------

Signed-off-by: gitdallas <dallas.nicol@gmail.com>
patternfly-build and others added 16 commits January 10, 2024 16:52
 - @patternfly/react-code-editor@5.2.0-prerelease.45
 - @patternfly/react-core@5.2.0-prerelease.44
 - @patternfly/react-docs@6.2.0-prerelease.45
 - @patternfly/react-drag-drop@5.2.0-prerelease.2
 - demo-app-ts@5.1.1-prerelease.67
 - @patternfly/react-table@5.2.0-prerelease.44
 - @patternfly/react-charts@7.2.0-prerelease.9
 - @patternfly/react-code-editor@5.2.0-prerelease.46
 - @patternfly/react-core@5.2.0-prerelease.45
 - @patternfly/react-docs@6.2.0-prerelease.46
 - @patternfly/react-drag-drop@5.2.0-prerelease.3
 - @patternfly/react-icons@5.2.0-prerelease.10
 - demo-app-ts@5.1.1-prerelease.68
 - @patternfly/react-table@5.2.0-prerelease.45
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…y#9941)

* FileUploadField name attribute fix

* update snapshots

* prevent breaking change

---------

Co-authored-by: nicolethoen <nthoen@redhat.com>
 - @patternfly/react-code-editor@5.2.0-prerelease.47
 - @patternfly/react-core@5.2.0-prerelease.46
 - @patternfly/react-docs@6.2.0-prerelease.47
 - @patternfly/react-drag-drop@5.2.0-prerelease.4
 - demo-app-ts@5.1.1-prerelease.69
 - @patternfly/react-table@5.2.0-prerelease.46
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat(charts): Victory dependency update

Closes patternfly#9960

* chore(charts): update lodash dependency
 - @patternfly/react-charts@7.2.0-prerelease.10
 - @patternfly/react-docs@6.2.0-prerelease.48
 - @patternfly/react-code-editor@5.2.0-prerelease.48
 - @patternfly/react-core@5.2.0-prerelease.47
 - @patternfly/react-docs@6.2.0-prerelease.49
 - @patternfly/react-drag-drop@5.2.0-prerelease.5
 - demo-app-ts@5.1.1-prerelease.70
 - @patternfly/react-table@5.2.0-prerelease.47
 - @patternfly/react-code-editor@5.2.0-prerelease.49
 - @patternfly/react-core@5.2.0-prerelease.48
 - @patternfly/react-docs@6.2.0-prerelease.50
 - @patternfly/react-drag-drop@5.2.0-prerelease.6
 - demo-app-ts@5.1.1-prerelease.71
 - @patternfly/react-table@5.2.0-prerelease.48
 - @patternfly/react-docs@6.2.0-prerelease.51
 - @patternfly/react-drag-drop@5.2.0-prerelease.7
@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 22, 2024

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My updates from main look good, Accordion is working well with both main + v6 updates I had made.

Am noticing that in dark theme the accordion toggle's hover styling is no longer working/the same as when the core PR went in. @lboehling was there an update made to either the --pf-t--global--background--color--action--plain--default or --pf-t--global--background--color--action--plain--hover tokens recently? When I build the core repo locally I'm also noticing that the background color isn't changing on hover in dark theme on the accordion toggle, but in the original core PR it's working fine.

@lboehling
Copy link
Collaborator

lboehling commented Jan 24, 2024

Am noticing that in dark theme the accordion toggle's hover styling is no longer working/the same as when the core PR went in. @lboehling was there an update made to either the --pf-t--global--background--color--action--plain--default or --pf-t--global--background--color--action--plain--hover tokens recently? When I build the core repo locally I'm also noticing that the background color isn't changing on hover in dark theme on the accordion toggle, but in the original core PR it's working fine.

@thatblindgeye no, there haven't been any updates made to those tokens recently as far as i know. Is the mix blend mode token being added to the hover state?

I'm also noticing that the expanded state bkg looks different from the original core PR too.

@kmcfaul kmcfaul merged commit 4a58c89 into patternfly:v6 Jan 25, 2024
13 checks passed
@tlabaj tlabaj mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.