Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PF4 Dropdown typescript issues (regression) #933

Closed
dlabrecq opened this issue Nov 17, 2018 · 1 comment · Fixed by #935
Closed

PF4 Dropdown typescript issues (regression) #933

dlabrecq opened this issue Nov 17, 2018 · 1 comment · Fixed by #935
Milestone
1.0.0-alpha.6

Comments

@dlabrecq
Copy link
Member

I installed the latest react-core package and the typescript issues previously fixed have cropped back in again. In particular, with the toggle property.

I believe the change below caused the regression.
#900

Typescript errors:
screen shot 2018-11-16 at 7 46 16 pm

My Dropdown usage:
screen shot 2018-11-16 at 7 47 03 pm
@dmiller9911
Copy link
Contributor

https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-4/react-core/src/components/Dropdown/Dropdown.d.ts#L14 that should be ReactNode. Could make it potentially more strict with ReactElement, but I don't see much value in that.

dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Nov 17, 2018
@dlabrecq
fix(dropdown): address typescript issue with toggle prop
e0dcfae 
Fixes patternfly#933
@dlabrecq dlabrecq mentioned this issue Nov 17, 2018
Merged
dlabaj pushed a commit that referenced this issue Nov 20, 2018
@dlabrecq @dlabaj
fix(dropdown): address typescript issue with toggle prop (#935)
8341297 
Fixes #933
@LHinson LHinson added this to the 1.0.0-alpha.6 milestone Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-alpha.6
Development

Successfully merging a pull request may close this issue.

Fix Dropdown typescript issue dlabrecq/patternfly-react
3 participants
@LHinson @dmiller9911 @dlabrecq