Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Modal and About Modal components to set 'overflow: hidden' on body when open #724

Closed
tlabaj opened this issue Oct 8, 2018 · 1 comment
Closed

Update Modal and About Modal components to set 'overflow: hidden' on body when open #724

tlabaj opened this issue Oct 8, 2018 · 1 comment
Assignees
@tlabaj
Milestone
1.0.0-alpha.6

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Oct 8, 2018 •
edited
Loading

Modal - body should be set to overflow: hidden when modal is open
Depends on patternfly-next issue: #793
@tlabaj tlabaj self-assigned this Oct 8, 2018
@LHinson LHinson modified the milestones: 1.0.0-alpha.4, 1.0.0-alpha.5 Oct 8, 2018
@tlabaj tlabaj added the PF4 label Oct 16, 2018
tlabaj added a commit to tlabaj/patternfly-react that referenced this issue Nov 7, 2018
@tlabaj
fix(PF4 AboutModal and Modal): added a class to the body when the Mod…
63fee16 
…al is open to set overflow to h

patternfly#724
@tlabaj tlabaj mentioned this issue Nov 7, 2018
Merged
tlabaj added a commit to tlabaj/patternfly-react that referenced this issue Nov 12, 2018
@tlabaj
fix(PF4 AboutModal and Modal): added a class to the body when the Mod…
5d71806 
…al is open to set overflow to h

patternfly#724
@LHinson LHinson modified the milestones: 1.0.0-alpha.5, 1.0.0-alpha.6 Nov 13, 2018
dlabaj pushed a commit that referenced this issue Nov 13, 2018
@tlabaj @dlabaj
fix(PF4 AboutModal and Modal): added a class to the body when the Mod… (
5b12b97 
#895)

* fix(PF4 AboutModal and Modal): added a class to the body when the Modal is open to set overflow to h

#724

* update based on comments

* updates from review

* remove imports in ModalContent
@tlabaj tlabaj closed this as completed Nov 26, 2018
@tlabaj
Copy link
Contributor Author

tlabaj commented Nov 26, 2018

closed by #895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlabaj tlabaj

Labels
None yet
Projects
None yet
Milestone
1.0.0-alpha.6
Development

No branches or pull requests
2 participants
@LHinson @tlabaj