virtualized sorting

patternfly · Jan 26, 2019 · b23bde8 · b23bde8
1 parent d04e4c0
commit b23bde8
Show file tree

Hide file tree

Showing 12 changed files with 480 additions and 62 deletions.
diff --git a/packages/patternfly-4/react-docs/package.json b/packages/patternfly-4/react-docs/package.json
@@ -38,8 +38,8 @@
     "gatsby"
   ],
   "scripts": {
-    "docbuild": "node build/copyDocs.js && gatsby build",
-    "pr-build": "node build/copyDocs.js && gatsby build --prefix-paths",
+    "docbuild": "node build/copyDocs.js && node --max_old_space_size=4096 ./node_modules/.bin/gatsby build",
+    "pr-build": "node build/copyDocs.js && node --max_old_space_size=4096 ./node_modules/.bin/gatsby build --prefix-paths",
     "develop": "gatsby develop"
   },
   "browserslist": [

diff --git a/packages/patternfly-4/react-table/src/components/Table/Body.js b/packages/patternfly-4/react-table/src/components/Table/Body.js
@@ -25,13 +25,18 @@ class ContextBody extends React.Component {
   onRow = (row, props) => {
     const { onRowClick, onRow } = this.props;
 
-    // if we have a parent onRow, call it to retrieve the resulting props
-    const parentRowProps = onRow ? onRow(row, props) : {};
+    // if we have an extended onRow, call it to retrieve the resulting props
+    const extendedRowProps = onRow ? onRow(row, props) : {};
+    const rowProps = {
+      ...props,
+      ...row.props,
+      ...extendedRowProps
+    };
     return {
       isExpanded: row.isExpanded,
       isOpen: row.isOpen,
       onClick: event => onRowClick(event, row, props),
-      ...parentRowProps
+      ...rowProps
     };
   };
 

diff --git a/packages/patternfly-4/react-table/src/components/Table/RowWrapper.js b/packages/patternfly-4/react-table/src/components/Table/RowWrapper.js
@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
 import { tableExpandableRow, modifiers } from '@patternfly/patternfly-next/components/Table/table.css';
 import { css } from '@patternfly/react-styles';
 
-const RowWrapper = ({ isOpen, isExpanded, trRef, ...props }) => (
+const RowWrapper = ({ isOpen, isExpanded, trRef, rowIndex, rowKey, ...props }) => (
   <tr
     {...props}
     ref={trRef}
@@ -13,13 +13,17 @@ const RowWrapper = ({ isOpen, isExpanded, trRef, ...props }) => (
 );
 
 RowWrapper.propTypes = {
-  trRef: PropTypes.oneOfType([PropTypes.func, PropTypes.shape({ current: PropTypes.instanceOf(Element) })]),
+  trRef: PropTypes.object,
+  rowIndex: PropTypes.number,
+  rowKey: PropTypes.string,
   isOpen: PropTypes.bool,
   isExpanded: PropTypes.bool
 };
 
 RowWrapper.defaultProps = {
   trRef: undefined,
+  rowIndex: undefined,
+  rowKey: undefined,
   isOpen: undefined,
   isExpanded: undefined
 };