fix(ClipboardCopy): remove popoverposition (#8226)

* fix(ClipboardCopy): remove popoverposition * edit doc comment * remove popover type from clipboardcopybutton
patternfly · Oct 13, 2022 · a9f8ef0 · a9f8ef0
1 parent 3812ffc
commit a9f8ef0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx b/packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx
@@ -2,7 +2,6 @@ import * as React from 'react';
 import styles from '@patternfly/react-styles/css/components/ClipboardCopy/clipboard-copy';
 import { css } from '@patternfly/react-styles';
 import { PickOptional } from '../../helpers/typeUtils';
-import { PopoverPosition } from '../Popover';
 import { TooltipPosition } from '../Tooltip';
 import { TextInput } from '../TextInput';
 import { GenerateId } from '../../helpers/GenerateId/GenerateId';
@@ -53,9 +52,8 @@ export interface ClipboardCopyProps extends Omit<React.HTMLProps<HTMLDivElement>
   isBlock?: boolean;
   /** Adds Clipboard Copy variant styles. */
   variant?: typeof ClipboardCopyVariant | 'inline' | 'expansion' | 'inline-compact';
-  /** Copy button popover position. */
+  /** Copy button tooltip position. */
   position?:
-    | PopoverPosition
     | TooltipPosition
     | 'auto'
     | 'top'
@@ -109,7 +107,7 @@ export class ClipboardCopy extends React.Component<ClipboardCopyProps, Clipboard
     isExpanded: false,
     isCode: false,
     variant: 'inline',
-    position: PopoverPosition.top,
+    position: TooltipPosition.top,
     maxWidth: '150px',
     exitDelay: 1600,
     entryDelay: 300,

diff --git a/packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx b/packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx
@@ -2,7 +2,6 @@ import * as React from 'react';
 import CopyIcon from '@patternfly/react-icons/dist/esm/icons/copy-icon';
 import { Button } from '../Button';
 import { Tooltip, TooltipPosition } from '../Tooltip';
-import { PopoverPosition } from '../Popover';
 
 export interface ClipboardCopyButtonProps
   extends Omit<React.DetailedHTMLProps<React.ButtonHTMLAttributes<HTMLButtonElement>, HTMLButtonElement>, 'ref'> {
@@ -25,7 +24,6 @@ export interface ClipboardCopyButtonProps
   /** Position of the copy button tooltip */
   position?:
     | TooltipPosition
-    | PopoverPosition
     | 'auto'
     | 'top'
     | 'bottom'