-
Notifications
You must be signed in to change notification settings - Fork 357
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
break out helpertextitem tests, update tests
- Loading branch information
Showing
4 changed files
with
141 additions
and
78 deletions.
There are no files selected for viewing
89 changes: 40 additions & 49 deletions
89
packages/react-core/src/components/HelperText/__tests__/HelperText.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,75 +1,66 @@ | ||
import * as React from 'react'; | ||
import { render, screen } from '@testing-library/react'; | ||
import { HelperText } from '../HelperText'; | ||
import { HelperTextItem } from '../HelperTextItem'; | ||
|
||
import styles from '@patternfly/react-styles/css/components/HelperText/helper-text'; | ||
|
||
test('Renders to match snapshot', () => { | ||
const { asFragment } = render( | ||
<HelperText> | ||
<HelperTextItem>help test text</HelperTextItem> | ||
<HelperTextItem>help test text 2</HelperTextItem> | ||
<HelperTextItem>help test text 3</HelperTextItem> | ||
</HelperText> | ||
); | ||
const { asFragment } = render(<HelperText />); | ||
expect(asFragment()).toMatchSnapshot(); | ||
}); | ||
|
||
test('HelperText renders custom className', () => { | ||
test('Renders without children', () => { | ||
render( | ||
<HelperText className="custom" data-testid="helper"> | ||
<HelperTextItem>help test text 1</HelperTextItem> | ||
</HelperText> | ||
<div data-testid="container"> | ||
<HelperText /> | ||
</div> | ||
); | ||
expect(screen.getByTestId('helper')).toHaveClass('custom'); | ||
|
||
expect(screen.getByTestId('container').firstChild).toBeVisible(); | ||
}); | ||
|
||
Object.values(['indeterminate', 'warning', 'success', 'error']).forEach((variant) => { | ||
test(`Renders ${styles.modifiers[variant]} when variant = ${variant}`, () => { | ||
render( | ||
<HelperTextItem variant={variant as 'default' | 'indeterminate' | 'warning' | 'success' | 'error'}> | ||
text | ||
</HelperTextItem> | ||
); | ||
expect(screen.getByText('text').parentElement).toHaveClass(styles.modifiers[variant]); | ||
}); | ||
test('Renders default classes', () => { | ||
render(<HelperText>text</HelperText>); | ||
expect(screen.getByText('text')).toHaveClass(styles.helperText); | ||
}); | ||
|
||
test('HelperTextItem renders custom className', () => { | ||
render( | ||
<HelperText> | ||
<HelperTextItem className="custom">help test text 1</HelperTextItem> | ||
</HelperText> | ||
); | ||
expect(screen.getByText('help test text 1').parentElement).toHaveClass('custom'); | ||
test('Renders id when id is passed', () => { | ||
render(<HelperText id="helper-id">text </HelperText>); | ||
expect(screen.getByText('text')).toHaveAttribute('id'); | ||
}); | ||
|
||
test('Renders as ul when component = ul', () => { | ||
render( | ||
<HelperText component="ul" aria-label="helper"> | ||
<HelperTextItem component="li">help test text 1</HelperTextItem> | ||
<HelperTextItem component="li">help test text 2</HelperTextItem> | ||
</HelperText> | ||
); | ||
expect(screen.getByLabelText('helper').tagName).toBe('UL'); | ||
expect(screen.getByText('help test text 1').parentElement?.tagName).toBe('LI'); | ||
test('Renders aria-live when isLiveRegion is passed', () => { | ||
render(<HelperText isLiveRegion>text </HelperText>); | ||
expect(screen.getByText('text')).toHaveAttribute('aria-live'); | ||
}); | ||
|
||
test('Renders custom icon', () => { | ||
render( | ||
<HelperText> | ||
<HelperTextItem icon={<div>test</div>}>help test text</HelperTextItem> | ||
</HelperText> | ||
); | ||
expect(screen.getByText('test').parentElement).toHaveClass(styles.helperTextItemIcon); | ||
test('Spreads additional props when passed', () => { | ||
render(<HelperText>text </HelperText>); | ||
expect(screen.getByText('text')).toBeInTheDocument(); | ||
}); | ||
|
||
test('Renders custom className', () => { | ||
render(<HelperText className="custom">text </HelperText>); | ||
expect(screen.getByText('text')).toHaveClass('custom'); | ||
}); | ||
|
||
test('Renders dynamic helper text', () => { | ||
test('Renders with element passed to component prop', () => { | ||
render(<HelperText component="ul">text</HelperText>); | ||
expect(screen.getByText('text').tagName).toBe('UL'); | ||
}); | ||
|
||
test('Renders aria-label and role when component = ul', () => { | ||
render( | ||
<HelperText> | ||
<HelperTextItem isDynamic>help test text</HelperTextItem> | ||
<HelperText component="ul" aria-label="helper"> | ||
text | ||
</HelperText> | ||
); | ||
expect(screen.getByText('help test text').parentElement).toHaveClass(styles.modifiers.dynamic); | ||
expect(screen.getByText('text')).toHaveAttribute('aria-label', 'helper'); | ||
expect(screen.getByText('text')).toHaveAttribute('role', 'list'); | ||
}); | ||
|
||
test('Does not render aria-label and role when component != ul', () => { | ||
render(<HelperText aria-label="helper">text</HelperText>); | ||
expect(screen.getByText('text')).not.toHaveAttribute('aria-label', 'helper'); | ||
expect(screen.getByText('text')).not.toHaveAttribute('role', 'list'); | ||
}); |
85 changes: 85 additions & 0 deletions
85
packages/react-core/src/components/HelperText/__tests__/HelperTextItem.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
import * as React from 'react'; | ||
import { render, screen } from '@testing-library/react'; | ||
import { HelperText } from '../HelperText'; | ||
import { HelperTextItem } from '../HelperTextItem'; | ||
|
||
import styles from '@patternfly/react-styles/css/components/HelperText/helper-text'; | ||
|
||
test('Renders to match snapshot', () => { | ||
const { asFragment } = render(<HelperTextItem>help test text</HelperTextItem>); | ||
expect(asFragment()).toMatchSnapshot(); | ||
}); | ||
|
||
test('Renders without children', () => { | ||
render( | ||
<div data-testid="container"> | ||
<HelperTextItem /> | ||
</div> | ||
); | ||
|
||
expect(screen.getByTestId('container').firstChild).toBeVisible(); | ||
}); | ||
|
||
test('Renders default classes', () => { | ||
render(<HelperTextItem>help test text 1</HelperTextItem>); | ||
expect(screen.getByText('help test text 1')).toHaveClass(styles.helperTextItemText); | ||
expect(screen.getByText('help test text 1').parentElement).toHaveClass(styles.helperTextItem); | ||
}); | ||
|
||
test('Renders custom className', () => { | ||
render(<HelperTextItem className="custom">help test text 1</HelperTextItem>); | ||
expect(screen.getByText('help test text 1').parentElement).toHaveClass('custom'); | ||
}); | ||
|
||
Object.values(['indeterminate', 'warning', 'success', 'error']).forEach((variant) => { | ||
test(`Renders with class ${styles.modifiers[variant]} when variant = ${variant}`, () => { | ||
render( | ||
<HelperTextItem variant={variant as 'default' | 'indeterminate' | 'warning' | 'success' | 'error'}> | ||
text | ||
</HelperTextItem> | ||
); | ||
expect(screen.getByText('text').parentElement).toHaveClass(styles.modifiers[variant]); | ||
}); | ||
}); | ||
|
||
test('Renders id when id is passed', () => { | ||
render(<HelperTextItem id="text-item">help test text 1</HelperTextItem>); | ||
expect(screen.getByText('help test text 1').parentElement).toHaveAttribute('id', 'text-item'); | ||
}); | ||
|
||
test('Renders as div by default when component is not passed', () => { | ||
render(<HelperTextItem>help test text 1</HelperTextItem>); | ||
expect(screen.getByText('help test text 1').parentElement?.tagName).toBe('DIV'); | ||
}); | ||
|
||
test('Renders with element passed to component prop', () => { | ||
render(<HelperTextItem component="li">help test text 1</HelperTextItem>); | ||
expect(screen.getByText('help test text 1').parentElement?.tagName).toBe('LI'); | ||
}); | ||
|
||
test('Renders custom icon', () => { | ||
render(<HelperTextItem icon={<div>test</div>}>help test text</HelperTextItem>); | ||
expect(screen.getByText('test').parentElement).toHaveClass(styles.helperTextItemIcon); | ||
}); | ||
|
||
test('Renders default icon when hasIcon = true and icon is not passed', () => { | ||
render(<HelperTextItem hasIcon>help test text</HelperTextItem>); | ||
expect(screen.getByText('help test text').parentElement?.querySelector('span')).toHaveClass( | ||
styles.helperTextItemIcon | ||
); | ||
}); | ||
|
||
test('Renders custom icon when icon is passed and hasIcon = true', () => { | ||
render( | ||
<HelperTextItem hasIcon icon={<div>test</div>}> | ||
help test text | ||
</HelperTextItem> | ||
); | ||
expect(screen.getByText('test').parentElement).toHaveClass(styles.helperTextItemIcon); | ||
}); | ||
|
||
test('Renders dynamic helper text', () => { | ||
render(<HelperTextItem isDynamic>help test text</HelperTextItem>); | ||
expect(screen.getByText('help test text').parentElement).toHaveClass(styles.modifiers.dynamic); | ||
expect(screen.getByText('help test text').querySelector('span')).toHaveClass('pf-v5-screen-reader'); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
...react-core/src/components/HelperText/__tests__/__snapshots__/HelperTextItem.test.tsx.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`Renders to match snapshot 1`] = ` | ||
<DocumentFragment> | ||
<div | ||
class="pf-v5-c-helper-text__item" | ||
> | ||
<span | ||
class="pf-v5-c-helper-text__item-text" | ||
> | ||
help test text | ||
</span> | ||
</div> | ||
</DocumentFragment> | ||
`; |