Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested type parameters in TS example #2923

Closed
wants to merge 1 commit into from
Closed

Fix nested type parameters in TS example #2923

wants to merge 1 commit into from

Conversation

CooperRedhat
Copy link
Contributor

Re: patternfly/patternfly-react#7219

Fix nested type parameters

  • acorn (and the acorn-typescript extension) treated >> as a single token
  • There is likely a better way to do this, but this seems to fix the problem
    • Potential issue would be someone using >> in a bitwise operation, but very unlikely that bitwise operations are happening in our react examples

@CooperRedhat
Copy link
Contributor Author

Example code do not merge

@patternfly-build
Copy link
Contributor

PF4 preview: https://patternfly-org-pr-2923-v4.surge.sh/v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CooperRedhat @patternfly-build