-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MessageBox): Adjust spacing #323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some musings~
packages/module/patternfly-docs/content/extensions/virtual-assistant/examples/UI/UI.md
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/virtual-assistant/examples/UI/UI.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no design feedback! noodling on erins comments about combining the 2 demos or having them be deliberate to the interaction
8258176
to
b743188
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't load the preview right now (thanks surge), so I'm going off of the written context. If I'm misunderstanding anything just lmk!
packages/module/patternfly-docs/content/extensions/virtual-assistant/examples/UI/UI.md
Outdated
Show resolved
Hide resolved
|
||
return ( | ||
<> | ||
<FormGroup role="radiogroup" isInline fieldId="basic-form-radio-group" label="Direction"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be labeled "Position"
since that's the prop name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All set!
WelcomePrompt had spacing on top, while MessageBox didn't. I moved the spacing onto the parent since WelcomePrompt is optional. Also adding prop to control position of MessageBox content, and adding a demo for how the removal interaction could work. Design wants to demonstrate the welcome message going away when new messages are sent.
9d57651
to
9caed0a
Compare
🎉 This PR is included in version 2.1.0-prerelease.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
WelcomePrompt had spacing on top, while MessageBox didn't. I moved the spacing onto the parent since WelcomePrompt is optional. Also adding prop to control position of MessageBox content, and adding a demo for how the removal interaction could work. Design wants to demonstrate the welcome message going away when new messages are sent.
See https://virtual-assistant-pr-virtual-assistant-323.surge.sh/patternfly-ai/chatbot/ui/react/welcome-interaction/ and https://virtual-assistant-pr-virtual-assistant-323.surge.sh/patternfly-ai/chatbot/ui#welcome-interaction.
Getting a screenshots error; will debug and add those later: