Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MessageBox): Adjust spacing #323

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

rebeccaalpert
Copy link
Member

@rebeccaalpert rebeccaalpert commented Nov 15, 2024

WelcomePrompt had spacing on top, while MessageBox didn't. I moved the spacing onto the parent since WelcomePrompt is optional. Also adding prop to control position of MessageBox content, and adding a demo for how the removal interaction could work. Design wants to demonstrate the welcome message going away when new messages are sent.

See https://virtual-assistant-pr-virtual-assistant-323.surge.sh/patternfly-ai/chatbot/ui/react/welcome-interaction/ and https://virtual-assistant-pr-virtual-assistant-323.surge.sh/patternfly-ai/chatbot/ui#welcome-interaction.

Getting a screenshots error; will debug and add those later:

npm run docs:screenshots

> @patternfly/virtual-assistant@1.0.0-prerelease.0 docs:screenshots
> pf-docs-framework screenshots --urlPrefix http://localhost:5001

/Users/ralpert/Documents/virtual-assistant/node_modules/puppeteer-cluster/dist/Worker.js:41
                        throw new Error('Unable to get browser page');
                              ^

Error: Unable to get browser page
    at Worker.<anonymous> (/Users/ralpert/Documents/virtual-assistant/node_modules/puppeteer-cluster/dist/Worker.js:41:31)
    at Generator.next (<anonymous>)
    at fulfilled (/Users/ralpert/Documents/virtual-assistant/node_modules/puppeteer-cluster/dist/Worker.js:5:58)

Node.js v22.6.0
npm error Lifecycle script `docs:screenshots` failed with error:
npm error code 1
npm error path /Users/ralpert/Documents/virtual-assistant/packages/module
npm error workspace @patternfly/virtual-assistant@1.0.0-prerelease.0
npm error location /Users/ralpert/Documents/virtual-assistant/packages/module
npm error command failed
npm error command sh -c pf-docs-framework screenshots --urlPrefix http://localhost:5001

@patternfly-build
Copy link

patternfly-build commented Nov 15, 2024

Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some musings~

Copy link

@kaylachumley kaylachumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no design feedback! noodling on erins comments about combining the 2 demos or having them be deliberate to the interaction

Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't load the preview right now (thanks surge), so I'm going off of the written context. If I'm misunderstanding anything just lmk!


return (
<>
<FormGroup role="radiogroup" isInline fieldId="basic-form-radio-group" label="Direction">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be labeled "Position" since that's the prop name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set!

WelcomePrompt had spacing on top, while MessageBox didn't. I moved the spacing onto the parent since WelcomePrompt is optional. Also adding prop to control position of MessageBox content, and adding a demo for how the removal interaction could work. Design wants to demonstrate the welcome message going away when new messages are sent.
@nicolethoen nicolethoen merged commit d8cb34f into patternfly:main Nov 21, 2024
5 checks passed
Copy link

🎉 This PR is included in version 2.1.0-prerelease.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for positioning of welcome messages Adjust spacing on welcome message
5 participants