feat(ChatbotModal): Add style-able modal for general use #307
Conversation
rebeccaalpert
force-pushed
the
custom-modal
branch
3 times, most recently
from
efdf26d to
4247575
Compare
There was a problem hiding this comment.
I noticed that when you open the modal, the close button seems to be in a hover state by default (until you click into the modal). Not sure if that's how it's meant to be, so I just wanted to mention!
little rewording, but I'm more than open to tweaking it more~
...ages/module/patternfly-docs/content/extensions/virtual-assistant/examples/Chatbot/Chatbot.md
Outdated
Show resolved
Hide resolved
rebeccaalpert
force-pushed
the
custom-modal
branch
3 times, most recently
from
e9a2c67 to
829b8de
Compare
rebeccaalpert
force-pushed
the
custom-modal
branch
2 times, most recently
from
d4860d5 to
b7b1530
Compare
rebeccaalpert
force-pushed
the
custom-modal
branch
from
b7b1530 to
7cece91
Compare
|
|
||
| ### Modal | ||
|
|
||
| Based on the [PatternFly modal](/components/modal), this modal adapts to the chatbot display mode and accepts components typically used in a modal. It is primarily used and tested in the context of the [attachment modals](/patternfly-ai/chatbot/messages#attachment-preview), but you can customize this modal to adapt it to other use cases as needed. |
There was a problem hiding this comment.
Is it true and/or worth noting that the modal will overlay the chatbot depending on the display mode of the chatbot? and should that something we can demonstrate in the example?
There was a problem hiding this comment.
I can add it to the example. What do you think @edonehoo? I'm fine with adding that; maybe this?
Based on the PatternFly modal, this modal adapts to the chatbot display mode and accepts components typically used in a modal. It is primarily used and tested in the context of the attachment modals, but you can customize this modal to adapt it to other use cases as needed. The modal will overlay the chatbot in default and docked modes, and will behave more like a traditional PatternFly modal in fullscreen and embedded modes.
There was a problem hiding this comment.
I think that sounds great!
There was a problem hiding this comment.
Thanks! Just updated both the text and example; let me know if you like this any better.
Add chatbot to example and update text.
|
🎉 This PR is included in version 2.1.0-prerelease.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Exposing the parent of the code modal so you can put whatever you want in it and pick up the style changes we've made for chatbot.
I tested against everything in regular PF. Custom sizes and widths won't work, and the wizard won't work outside of fullscreen without some adjustments, but every other example from our site plugs in and looks non-broken to me.