fix(FileDetails/FileDetailsLabel): Adjust chip width #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccaalpert
force-pushed
the
label-width
branch
from
d449138 to
60bd2d9
Compare
kaylachumley
approved these changes
Oct 22, 2024
|
@rebeccaalpert needs rebase |
We were relying on the default PatternFly label behavior for long titles. Mark raised a concern that this will cause problems in the future when we enable multiple file uploads. This PR adjusts the chip so it has text truncation and a max width.
rebeccaalpert
force-pushed
the
label-width
branch
from
60bd2d9 to
32add41
Compare
|
Should be all set @nicolethoen! |
nicolethoen
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were relying on the default PatternFly label behavior for long titles. Mark raised a concern that this will cause problems in the future when we enable multiple file uploads. This PR adjusts the chip so it has text truncation and a max width. The loading state should also look a little more consistent when titles are long.
Modals use the same text treatment, meaning that they will have truncation.
Short title:
Long title:
