Issue #2: Fake pattern-specific data #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke pattern-specific data
AndyIRC
changed the title
|
+1 |
nerfchicken
approved these changes
Feb 1, 2019
nerfchicken
added a commit
to nerfchicken/plugin-php-faker
that referenced
this pull request
Feb 5, 2019
Since these 2 pull requests haven't been accepted, I forked the project: pattern-lab#7 pattern-lab#8
|
Works for me as well. Thank you! @EvanLovely Consider merging this? Please? :) |
|
This PR worked for me as well. Would love to see it merged. |
|
Released in: https://github.com/pattern-lab/plugin-php-faker/releases/tag/v2.0.2 Sorry it took so long! |
|
New composer packagist release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix Issue #2. I just listen to an event dispatched later - by that time the pattern specific data is in the array.