-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): resolving broken links in new docs site #1192 #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
those don't have an eqivalent any more in the new docs space, so we're linking to their deprecation ticket.
plus readded that image that was additionally missing within the docs page /packages/docs/src/docs/advanced-ecosystem-overview.md
This is a permanent redirect. The link should be updated.
sghoweri
approved these changes
May 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your help updating these @mfranzke!
Any chance you could toss in a new ticket with the couple of bullet items you mentioned that are still outstanding / have unanswered questions so we can get the rest of this merged down?
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
fix(docs): resolving broken links in new docs site pattern-lab#1192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1192
Summary of changes:
Additionally to the changes out of #1153 there are some more links included in the several different files of the repo (.md, .js etc.) as comments or within these documentation files, that would additionally need to get changed.
Those are the links that needed to get changed:
http://patternlab.io/docs/advanced-ecosystem-overview.html (web archive) -> https://patternlab.io/docs/overview-of-pattern-lab's-ecosystem/
http://patternlab.io/docs/advanced-config-options.html#node (web archive) -> https://patternlab.io/docs/editing-the-configuration-options/
http://patternlab.io/docs/pattern-organization.html (web archive) -> https://patternlab.io/docs/overview-of-patterns/
http://patternlab.io/docs/pattern-including.html (web archive) -> https://patternlab.io/docs/including-patterns/
http://patternlab.io/docs/pattern-header-footer.html (web archive) -> https://patternlab.io/docs/modifying-the-pattern-header-and-footer/
http://patternlab.io/docs/pattern-adding-annotations.html (web archive) -> https://patternlab.io/docs/adding-annotations/
http://patternlab.io/docs/data-overview.html (web archive) -> https://patternlab.io/docs/overview-of-data/
http://patternlab.io/docs/pattern-hiding.html (web archive) -> https://patternlab.io/docs/hiding-patterns-in-the-navigation/
http://patternlab.io/docs/pattern-pseudo-patterns.html (web archive) -> https://patternlab.io/docs/using-pseudo-patterns/
http://patternlab.io/docs/pattern-states.html (web archive) -> https://patternlab.io/docs/using-pattern-states/
http://patternlab.io/docs/pattern-parameters.html (web archive) -> https://patternlab.io/docs/using-pattern-parameters/
http://patternlab.io/docs/advanced-starterkits.html (web archive) -> https://patternlab.io/docs/starterkits/
http://patternlab.io/docs/pattern-stylemodifier.html (web archive) -> Deprecate Style Modifiers #1177 (those don't have an eqivalent any more in the new docs space, so we're linking to their deprecation ticket)
http://patternlab.io/docs/ -> https://patternlab.io/docs/ (switching to
https
links just because)http://patternlab.io/download.html (web archive) -> https://patternlab.io/docs/installing-pattern-lab/
http://patternlab.io/assets/pattern-lab-2-image_18-large-opt.png (web archive) -> https://patternlab.io/images/pattern-lab-2-image_18-large-opt.png (plus readded that image that was additionally missing within the docs page
/packages/docs/src/docs/advanced-ecosystem-overview.md
) / deployed for testing at: https://deploy-preview-1193--patternlab-docs-preview.netlify.app/docs/overview-of-pattern-lab's-ecosystem/http://tinnedfruit.com/2016/09/20/why-and-how-to-test-your-pattern-library-2.html -> https://tinnedfruit.com/writing/why-and-how-to-test-your-pattern-library-2.html
http://tinnedfruit.com/2016/09/12/why-and-how-to-test-your-pattern-library.html -> https://tinnedfruit.com/writing/why-and-how-to-test-your-pattern-library.html
http://patterns.frostfinery.com (on https://patternlab.io/resources/) @bradfrost: this link doesn't work any more, is there a successor ?
http://www.brianmuenzenmeyer.com/adding-common-gulp-tasks-to-pattern-lab-node, http://www.brianmuenzenmeyer.com/using-patternlab-to-design-build-and-maintain-a-website & http://www.brianmuenzenmeyer.com/patternlab/public/ @bmuenzenmeyer: these links don't work any more, are there new ones you could provide?