Remove autoroute check from dropdownShouldBeActive #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 6, 2015 06:37
The autoroute check was redundant. The check would also break functionality where the user is manually managing link active status and has autorouting disabled.
Allow users to push content to the navbar header. This is useful for pushing images/icons/logos just before the branding output.
|
Have you a test for that? |
|
I don't have a test case for it. Let me try putting one together. |
|
Just spotted you've added another commit to this PR that for something else. Could you split that one into a seperate PR? It's just helpful for cleaning things up. |
|
This has been left for a bit long - does it still apply? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autoroute check was redundant. The check would also break functionality where the user is manually managing link active status and has autorouting disabled.