feat: update CI requirements for landing pull requests (#533)

Refs: nodejs/node#37308
patrickm68 · Feb 26, 2021 · 390a7a4 · 390a7a4
1 parent e0da2b7
commit 390a7a4
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 14 deletions.
diff --git a/lib/pr_checker.js b/lib/pr_checker.js
@@ -397,8 +397,8 @@ class PRChecker {
     return true;
   }
 
-  isOnlyDocChanges() {
-    const { cli, pr } = this;
+  requiresJenkinsRun() {
+    const { pr } = this;
 
     // NOTE(mmarchini): if files not present, fallback
     // to old behavior. This should only be the case on old tests
@@ -407,19 +407,37 @@ class PRChecker {
       return false;
     }
 
-    for (const { path } of pr.files.nodes) {
-      if (!path.endsWith('.md')) {
-        return false;
-      }
-    }
-    cli.info('Doc-only changes');
-    return true;
+    const ciNeededFolderRx = /^(deps|lib|src|test)\//;
+    const ciNeededToolFolderRx =
+      /^tools\/(code_cache|gyp|icu|inspector|msvs|snapshot|v8_gypfiles)/;
+    const ciNeededFileRx = /^tools\/\.+.py$/;
+    const ciNeededFileList = [
+      'tools/build-addons.js',
+      'configure',
+      'configure.py',
+      'Makefile'
+    ];
+    const ciNeededExtensionList = ['.gyp', '.gypi', '.bat'];
+
+    return pr.files.nodes.some(
+      ({ path }) =>
+        ciNeededFolderRx.test(path) ||
+        ciNeededToolFolderRx.test(path) ||
+        ciNeededFileRx.test(path) ||
+        ciNeededFileList.includes(path) ||
+        ciNeededExtensionList.some((ext) => path.endsWith(ext))
+    );
   }
 
   async checkNodejsCI() {
     let status = this.checkActionsCI();
-    if (!this.isOnlyDocChanges()) {
+    if (
+      this.pr.labels.nodes.some((l) => l.name === 'needs-ci') ||
+      this.requiresJenkinsRun()
+    ) {
       status &= await this.checkJenkinsCI();
+    } else {
+      this.cli.info('Green GitHub Actions CI is sufficient');
     }
     return status;
   }

diff --git a/test/fixtures/first_timer_pr.json b/test/fixtures/first_timer_pr.json
@@ -11,6 +11,9 @@
   "bodyText": "Awesome changes",
   "labels": {
     "nodes": [
+      {
+        "name": "needs-ci"
+      },
       {
         "name": "test"
       },

diff --git a/test/unit/pr_checker.test.js b/test/unit/pr_checker.test.js
@@ -655,7 +655,7 @@ describe('PRChecker', () => {
           ['No GitHub CI runs detected']
         ],
         info: [
-          ['Doc-only changes']
+          ['Green GitHub Actions CI is sufficient']
         ]
       };
 
@@ -697,7 +697,7 @@ describe('PRChecker', () => {
           ['Last GitHub Actions successful']
         ],
         info: [
-          ['Doc-only changes']
+          ['Green GitHub Actions CI is sufficient']
         ]
       };
 
@@ -741,7 +741,7 @@ describe('PRChecker', () => {
           ['Last GitHub Actions successful']
         ],
         info: [
-          ['Doc-only changes']
+          ['Green GitHub Actions CI is sufficient']
         ]
       };
 

diff --git a/test/unit/pr_summary.test.js b/test/unit/pr_summary.test.js
@@ -44,7 +44,7 @@ describe('PRSummary', () => {
           'Their Github Account email <pr_author@example.com>' +
           ' (@pr_author, first-time contributor)'],
         ['Branch', 'pr_author:awesome-changes -> nodejs:master'],
-        ['Labels', 'test, doc'],
+        ['Labels', 'needs-ci, test, doc'],
         ['Commits', '6'],
         ['Committers', '3']
       ]