Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap priority editor changed to slider (#49) #62

Merged
merged 3 commits into from
Apr 18, 2022

Conversation

jveer
Copy link
Contributor

@jveer jveer commented Apr 16, 2022

Adds the slider for #49

The value 0 is submitted to the saving endpoint as undefined so it will be stored as null in the database. Which means there is no longer an option to set the priority to 0.

If setting the priority to 0 should be available, we could maybe add a toggle input to enable the slider first? I'll leave it up to you to decide @patrickdemooij9 😉

@patrickdemooij9
Copy link
Owner

@jveer, that is a difficult one... 0 doesn't really indicate that the value would be excluded from the sitemap. So, I guess a toggle would probably be the way to go here

@jveer
Copy link
Contributor Author

jveer commented Apr 17, 2022

Updated the PR to add a checkbox to handle this situation

Checkbox disabled:
image

Checkbox enabled:
image

@patrickdemooij9
Copy link
Owner

@jveer
Getting the following error when going to a document type now:
image

Seems to be caused by this 'ng-if'. Replacing it with ng-show seems to fix it
image

@jveer
Copy link
Contributor Author

jveer commented Apr 17, 2022

@patrickdemooij9 thanks for testing it properly, the latest commit should resolve this issue

@patrickdemooij9 patrickdemooij9 merged commit d358662 into patrickdemooij9:main Apr 18, 2022
@patrickdemooij9
Copy link
Owner

Looking great! Tested it and works as expected. Thanks for the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants