Add tree group to constants #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good! Don't see how this could mess anything up. Can't wait to see the 404 extension PR! 🙌 |
patrickdemooij9
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Add SeoToolkitTreeGroupAlias to constants class * Use the TreeGroup alias constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@patrickdemooij9 We're considering an addition to one of our projects, specifically the inclusion of a 404 module to extend your package. To achieve this, we've developed a custom tree controller and integrated it into the same TreeGroup (the SeoToolkit TreeGroup). However, our current implementation involves the use of a hardcoded string, which we find somewhat precarious. If you decide to modify the alias of the tree group, our extension would cease to function. Therefore, we'd prefer to use a constant to ensure greater stability and compatibility. If you like the addition I can do this for the section alias as well.
Btw, as far as I know @Ambertvu has plans to create a PR to this repo with the 404 extension 😄!