Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seo Keywords added with Umbraco Tags Editor #198

Merged

Conversation

ugurhangul
Copy link

Users now able to add/edit keywords for pages

@patrickdemooij9
Copy link
Owner

Hi @ugurhangul,
Thank you so much for the PR. I'll take it for a swing and come back with any feedback I might have

@patrickdemooij9 patrickdemooij9 merged commit df990a8 into patrickdemooij9:dev/Umbraco11 Jul 4, 2023
@patrickdemooij9
Copy link
Owner

Hi @ugurhangul
Again thanks for your PR and sorry that I came back to you this late. I updated two things in your PR, but please let me know what you think of it.

  • I've moved the schema field to the Others group in the SEO tab. I think it doesn't really fit in the first tab as it seems a bit more technical for users than the other fields.
  • I've moved the keyword field behind a setting. I believe keywords aren't really used anymore in the search engines (I know Google doesn't do anything with it), so I don't really see the need to add it. But, if there are reasons for it, people can easily enable it and have it showing for their users.

@ugurhangul
Copy link
Author

Hello @patrickdemooij9 Thanks for feedback.

I don't know but Seo experts still using keywords. Thats why i added them. But its ok to be behind a settings.

Thanks for accepting merge. I can add package to the projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants