Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for wrong fallback image #147

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Fix for wrong fallback image #147

merged 1 commit into from
Jan 11, 2023

Conversation

patrickdemooij9
Copy link
Owner

Fixes #142

@patrickdemooij9 patrickdemooij9 merged commit bba70b6 into dev/Umbraco10 Jan 11, 2023
@patrickdemooij9 patrickdemooij9 deleted the bugfix/142 branch January 11, 2023 20:34
@ianleeder
Copy link
Contributor

@patrickdemooij9 Even if I set an image explicitly, it's not rendering an og:image meta tag. Same bug/fix, or new issue?

image

<meta name="description" content="A description we must have">
<meta property="og:title" content="test-og-title">
<meta property="og:description" content="test-og-description">
<link rel="canonical" href="https://localhost:44369/">
<meta name="robots" content="">

@patrickdemooij9
Copy link
Owner Author

I think this should also be fixed with the changes that I did, but I will double check it later today

patrickdemooij9 added a commit that referenced this pull request Jan 15, 2023
* Add content to SitemapNodeItem (#145)

Co-authored-by: Ian Leeder <ileeder@intuitiveit.com.au>

* Fix for wrong fallback image (#147)

* Fix issue with root canonical url (#150)

Co-authored-by: Ian Leeder <i_leeder@hotmail.com>
Co-authored-by: Ian Leeder <ileeder@intuitiveit.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants